[PR #162] [MERGED] Replace HaState & HaGroup by values from ReadVMHA #274

Closed
opened 2026-02-28 00:41:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/162
Author: @maximiliend
Created: 4/5/2022
Status: Merged
Merged: 4/6/2022
Merged by: @mleone87

Base: masterHead: dev/addHaGroupInConfigQemu


📝 Commits (1)

  • 583eec2 Replace HaState & HaGroup by values from ReadVMHA as hagroup is not returned by Proxmox API for VM ressource

📊 Changes

1 file changed (+10 additions, -6 deletions)

View changed files

📝 proxmox/config_qemu.go (+10 -6)

📄 Description

hagroup is not returned by Proxmox API for VM ressource, so like LXC config I tried to add the hagroup fetch from ReadVMHA()

This is essential for https://github.com/Telmate/terraform-provider-proxmox/issues/486 that cause non idempotent terraform commands for a VM with hagroup.

I'm new to this project and don't study the whole project, I sense that I probably forgot some things, feel free to change for a better behavior.

Kind Regards,


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/162 **Author:** [@maximiliend](https://github.com/maximiliend) **Created:** 4/5/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `dev/addHaGroupInConfigQemu` --- ### 📝 Commits (1) - [`583eec2`](https://github.com/Telmate/proxmox-api-go/commit/583eec2514cae8bd4a5952955a2d98121d261fc2) Replace HaState & HaGroup by values from ReadVMHA as hagroup is not returned by Proxmox API for VM ressource ### 📊 Changes **1 file changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+10 -6) </details> ### 📄 Description hagroup is not returned by Proxmox API for VM ressource, so like LXC config I tried to add the hagroup fetch from ReadVMHA() This is essential for https://github.com/Telmate/terraform-provider-proxmox/issues/486 that cause non idempotent terraform commands for a VM with hagroup. I'm new to this project and don't study the whole project, I sense that I probably forgot some things, feel free to change for a better behavior. Kind Regards, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:41:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#274
No description provided.