mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #162] [MERGED] Replace HaState & HaGroup by values from ReadVMHA #274
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#274
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/162
Author: @maximiliend
Created: 4/5/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @mleone87
Base:
master← Head:dev/addHaGroupInConfigQemu📝 Commits (1)
583eec2Replace HaState & HaGroup by values from ReadVMHA as hagroup is not returned by Proxmox API for VM ressource📊 Changes
1 file changed (+10 additions, -6 deletions)
View changed files
📝
proxmox/config_qemu.go(+10 -6)📄 Description
hagroup is not returned by Proxmox API for VM ressource, so like LXC config I tried to add the hagroup fetch from ReadVMHA()
This is essential for https://github.com/Telmate/terraform-provider-proxmox/issues/486 that cause non idempotent terraform commands for a VM with hagroup.
I'm new to this project and don't study the whole project, I sense that I probably forgot some things, feel free to change for a better behavior.
Kind Regards,
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
SnapshotName#362