[PR #164] [MERGED] Improve Authentik Support by handlign wildcards + DN #585

New issue

Closed

opened 2026-02-27 08:18:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:18:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/164
Author: @strazto
Created: 5/7/2022
Status: ✅ Merged
Merged: 5/12/2022
Merged by: @nitnelave

Base: main ← Head: handle_wildcards_distinguishedname

📝 Commits (4)

b2071d2 handle dn attribute being queried as distinguishedname
382b73b handle wildcards being given as ldap attribute params
ee5e137 ldap wildcard handler, add tests
2851a6a ldap wildcard handler, error if '*' attribute makes it to get_x_attribute

📊 Changes

1 file changed (+208 additions, -6 deletions)

View changed files

📝 server/src/infra/ldap_handler.rs (+208 -6)

📄 Description

Resolves #158

Review very welcome, I'm new to rust and found this challenging to write

Doesnt introduce regressions, but test cases are needed (I just don't want to write them 🙃 )

I haven't even run this against an authentik instance yet, I'll probably make a docker-compose for testing against one

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/164 **Author:** [@strazto](https://github.com/strazto) **Created:** 5/7/2022 **Status:** ✅ Merged **Merged:** 5/12/2022 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `handle_wildcards_distinguishedname` --- ### 📝 Commits (4) - [`b2071d2`](https://github.com/lldap/lldap/commit/b2071d29e25e89d4ac2e276b1f232476c0e5e9c7) handle dn attribute being queried as distinguishedname - [`382b73b`](https://github.com/lldap/lldap/commit/382b73b963f0894cb966c3a57e4f31b9d8d0d166) handle wildcards being given as ldap attribute params - [`ee5e137`](https://github.com/lldap/lldap/commit/ee5e137f1246b18883f83fc2e3430970aa8683d5) ldap wildcard handler, add tests - [`2851a6a`](https://github.com/lldap/lldap/commit/2851a6ac550fdd386f2ee91bf2f2aee5c8f4ceda) ldap wildcard handler, error if '*' attribute makes it to get_x_attribute ### 📊 Changes **1 file changed** (+208 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/src/infra/ldap_handler.rs` (+208 -6) </details> ### 📄 Description Resolves #158 Review very welcome, I'm new to rust and found this challenging to write Doesnt introduce regressions, but test cases are needed (I just don't want to write them 🙃 ) I haven't even run this against an authentik instance yet, I'll probably make a docker-compose for testing against one --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>