[PR #471] [CLOSED] softmixer: Reduce special-casing #942

New issue

Closed

opened 2026-02-27 20:00:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/471
Author: @v1ne
Created: 5/2/2020
Status: ❌ Closed

Base: dev ← Head: less-special-casing

📝 Commits (1)

8fe896f softmixer: Don't special-case unity gain

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 playback/src/mixer/softmixer.rs (+2 -4)

📄 Description

Sometimes saving a multiplication per sample doesn't seem to be worth the complication of the code, I'd say.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/471 **Author:** [@v1ne](https://github.com/v1ne) **Created:** 5/2/2020 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `less-special-casing` --- ### 📝 Commits (1) - [`8fe896f`](https://github.com/librespot-org/librespot/commit/8fe896fa8ffcd06bf47bbe920413fbc130d3bcb0) softmixer: Don't special-case unity gain ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/mixer/softmixer.rs` (+2 -4) </details> ### 📄 Description Sometimes saving a multiplication per sample doesn't seem to be worth the complication of the code, I'd say. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>