[PR #956] [MERGED] Port remove unsafe code and catch up new-api with dev #1161

New issue

Closed

opened 2026-02-27 20:01:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/956
Author: @JasonLG1979
Created: 1/30/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @roderickvd

Base: new-api ← Head: new-api

📝 Commits (10+)

5e8e2ba examples/playlist_tracks: Use normal URI parser
c6e97a7 Save some more CPU cycles in the limiter (#939)
ceebb37 Remove unsafe code (#940)
55ced49 Merge pull request #929 from jforberg/playlist_tracks
03e71f6 simplify get_factor (#942)
c8971dc Fix Alsa softvol linear mapping (#950)
3c749a8 Remove basic normalisation deprecation warning
f4be9bb Merge pull request #954 from JasonLG1979/remove-dep-warning
ccd72b6 Port https://github.com/librespot-org/librespot/pull/940
00f37da Merge branch 'dev' into new-api

📊 Changes

18 files changed (+370 additions, -245 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 connect/src/spirc.rs (+3 -3)
📝 core/src/cache.rs (+11 -6)
📝 core/src/file_id.rs (+4 -3)
📝 core/src/spclient.rs (+7 -7)
📝 core/src/spotify_id.rs (+38 -24)
📝 examples/playlist_tracks.rs (+7 -5)
📝 metadata/src/episode.rs (+1 -1)
📝 metadata/src/playlist/annotation.rs (+1 -1)
📝 metadata/src/playlist/list.rs (+2 -2)
📝 metadata/src/track.rs (+1 -1)
📝 playback/src/config.rs (+1 -1)
📝 playback/src/convert.rs (+17 -23)
📝 playback/src/dither.rs (+3 -3)
📝 playback/src/mixer/alsamixer.rs (+13 -2)
📝 playback/src/player.rs (+162 -112)
📝 src/main.rs (+5 -18)
📝 src/player_event_handler.rs (+90 -33)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/956 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 1/30/2022 **Status:** ✅ Merged **Merged:** 2/14/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `new-api` ← **Head:** `new-api` --- ### 📝 Commits (10+) - [`5e8e2ba`](https://github.com/librespot-org/librespot/commit/5e8e2ba8c59dbc3684244ca5180e930550e4cafc) examples/playlist_tracks: Use normal URI parser - [`c6e97a7`](https://github.com/librespot-org/librespot/commit/c6e97a7f8ab4b7d97b82427071b2f1555557e0cc) Save some more CPU cycles in the limiter (#939) - [`ceebb37`](https://github.com/librespot-org/librespot/commit/ceebb374f0db8848a8d4135c5a06b466f2d963e1) Remove unsafe code (#940) - [`55ced49`](https://github.com/librespot-org/librespot/commit/55ced49c2d0f6004ca752e9a736d85deddaa45c1) Merge pull request #929 from jforberg/playlist_tracks - [`03e71f6`](https://github.com/librespot-org/librespot/commit/03e71f6e0a94265c3a3106e34a87264cc9e825fd) simplify get_factor (#942) - [`c8971dc`](https://github.com/librespot-org/librespot/commit/c8971dce63f24a2e19da07fd5ce52e09bfdcf40e) Fix Alsa softvol linear mapping (#950) - [`3c749a8`](https://github.com/librespot-org/librespot/commit/3c749a8f0e66df865701bbfa36df37e8ef258b9e) Remove basic normalisation deprecation warning - [`f4be9bb`](https://github.com/librespot-org/librespot/commit/f4be9bb85d68005a29490ff19738a4beb7bbd81e) Merge pull request #954 from JasonLG1979/remove-dep-warning - [`ccd72b6`](https://github.com/librespot-org/librespot/commit/ccd72b6e909742f286b9ebdaef26ad04431a64e9) Port https://github.com/librespot-org/librespot/pull/940 - [`00f37da`](https://github.com/librespot-org/librespot/commit/00f37da2c30f0899b0ceaf85d13a759de59c5cd3) Merge branch 'dev' into new-api ### 📊 Changes **18 files changed** (+370 additions, -245 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `connect/src/spirc.rs` (+3 -3) 📝 `core/src/cache.rs` (+11 -6) 📝 `core/src/file_id.rs` (+4 -3) 📝 `core/src/spclient.rs` (+7 -7) 📝 `core/src/spotify_id.rs` (+38 -24) 📝 `examples/playlist_tracks.rs` (+7 -5) 📝 `metadata/src/episode.rs` (+1 -1) 📝 `metadata/src/playlist/annotation.rs` (+1 -1) 📝 `metadata/src/playlist/list.rs` (+2 -2) 📝 `metadata/src/track.rs` (+1 -1) 📝 `playback/src/config.rs` (+1 -1) 📝 `playback/src/convert.rs` (+17 -23) 📝 `playback/src/dither.rs` (+3 -3) 📝 `playback/src/mixer/alsamixer.rs` (+13 -2) 📝 `playback/src/player.rs` (+162 -112) 📝 `src/main.rs` (+5 -18) 📝 `src/player_event_handler.rs` (+90 -33) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:24 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1161

No description provided.

Rows
Columns