[PR #942] [MERGED] simplify get_factor #1154

Closed
opened 2026-02-27 20:01:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/942
Author: @JasonLG1979
Created: 1/23/2022
Status: Merged
Merged: 1/27/2022
Merged by: @roderickvd

Base: devHead: simplify-get_factor


📝 Commits (4)

  • 736a1e0 simplify get_factor
  • 7c1f31b Add info and warning messages and update changelog
  • 73d727d Merge branch 'librespot-org:dev' into simplify-get_factor
  • 75ec5c0 clean up

📊 Changes

2 files changed (+46 additions, -13 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/player.rs (+45 -13)

📄 Description

Less math and logic that follows the spec.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/942 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 1/23/2022 **Status:** ✅ Merged **Merged:** 1/27/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `simplify-get_factor` --- ### 📝 Commits (4) - [`736a1e0`](https://github.com/librespot-org/librespot/commit/736a1e05191de609eb9eb533f587394ba8dad2d6) simplify get_factor - [`7c1f31b`](https://github.com/librespot-org/librespot/commit/7c1f31beb66f1c802b9206cd93e6dd28bff27743) Add info and warning messages and update changelog - [`73d727d`](https://github.com/librespot-org/librespot/commit/73d727ddade7c7456b827a29095a0b53dce6b060) Merge branch 'librespot-org:dev' into simplify-get_factor - [`75ec5c0`](https://github.com/librespot-org/librespot/commit/75ec5c041d7f91457ec68c1e0c18a32f6f82eb37) clean up ### 📊 Changes **2 files changed** (+46 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/player.rs` (+45 -13) </details> ### 📄 Description Less math and logic that follows the spec. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1154
No description provided.