starred/librespot
1
0
Fork 0
mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00
Code Issues 95 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #845] Playlist::get panics if the playlist contains tracks from Local Files #424

New issue
Closed
opened 2026-02-27 19:30:32 +03:00 by kerem · 5 comments
kerem commented 2026-02-27 19:30:32 +03:00
Owner
Copy link

Originally created by @RainbowCookie32 on GitHub (Sep 14, 2021).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/845

Seems like SpotifyId::from_base62() can't handle tracks from local files, since it returns Err.

This leads to the unwrap() on the parse function called from Playlist::get (here) to cause a panic and crash my application with:

thread 'main' panicked at 'called 'Result::unwrap()' on an 'Err' value: SpotifyIdError', /home/rainbowcookie/.cargo/registry/src/github.com-1ecc6299db9ec823/librespot-metadata-0.2.0/src/lib.rs:296:54

It'd be nice for the error to be handled instead of just panicking. I don't know if handling local files is possible, but even just ignoring tracks whose SpotifyId returns Err would be a better stop-gag solution in my case.

Originally created by @RainbowCookie32 on GitHub (Sep 14, 2021). Original GitHub issue: https://github.com/librespot-org/librespot/issues/845 Seems like SpotifyId::from_base62() can't handle tracks from local files, since it returns Err. This leads to the unwrap() on the [parse function](https://github.com/librespot-org/librespot/blob/e27992a754b840e9c4591ebd32838cadaf51ebe8/metadata/src/lib.rs#L129) called from Playlist::get ([here](https://github.com/librespot-org/librespot/blob/e27992a754b840e9c4591ebd32838cadaf51ebe8/metadata/src/lib.rs#L297)) to cause a panic and crash my application with: ``` thread 'main' panicked at 'called 'Result::unwrap()' on an 'Err' value: SpotifyIdError', /home/rainbowcookie/.cargo/registry/src/github.com-1ecc6299db9ec823/librespot-metadata-0.2.0/src/lib.rs:296:54 ``` It'd be nice for the error to be handled instead of just panicking. I don't know if handling local files is possible, but even just ignoring tracks whose SpotifyId returns Err would be a better stop-gag solution in my case.
kerem 2026-02-27 19:30:32 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-02-27 19:30:33 +03:00
Author
Owner
Copy link

@roderickvd commented on GitHub (Sep 15, 2021):

Yeah, seems right. Do you know your way around Rust to submit a PR? I see more than one Rust project listed on your GitHub profile 😉

<!-- gh-comment-id:919823776 --> @roderickvd commented on GitHub (Sep 15, 2021): Yeah, seems right. Do you know your way around Rust to submit a PR? I see more than one Rust project listed on your GitHub profile 😉
kerem commented 2026-02-27 19:30:33 +03:00
Author
Owner
Copy link

@RainbowCookie32 commented on GitHub (Sep 15, 2021):

I can give it a spin. Would replacing

SpotifyId::from_base62(uri_parts[2]).unwrap()

with

if let Ok(id) = SpotifyId::from_base62(uri_parts[2]) {
  track
}

be good enough in your opinion? Not gonna lie, I've barely used map() (or most functions with iterators) in my time with Rust.

Edit: It's not

<!-- gh-comment-id:920125258 --> @RainbowCookie32 commented on GitHub (Sep 15, 2021): I can give it a spin. Would replacing ``` SpotifyId::from_base62(uri_parts[2]).unwrap() ``` with ``` if let Ok(id) = SpotifyId::from_base62(uri_parts[2]) { track } ``` be good enough in your opinion? Not gonna lie, I've barely used map() (or most functions with iterators) in my time with Rust. Edit: _It's not_
kerem commented 2026-02-27 19:30:33 +03:00
Author
Owner
Copy link

@RainbowCookie32 commented on GitHub (Sep 15, 2021):

Cooked this up. If it's fine, I can open a PR for it

<!-- gh-comment-id:920372387 --> @RainbowCookie32 commented on GitHub (Sep 15, 2021): Cooked [this](https://github.com/RainbowCookie32/librespot/commit/b75e8787e97deeba8fe389da407b56387bbadfd6) up. If it's fine, I can open a PR for it
kerem commented 2026-02-27 19:30:33 +03:00
Author
Owner
Copy link

@ashthespy commented on GitHub (Sep 16, 2021):

Try looking at filter_map :-)
Something like this should be sufficient.. (please do test though!)

diff --git a/metadata/src/lib.rs b/metadata/src/lib.rs
index cf663ce6..2ed9273e 100644
--- a/metadata/src/lib.rs
+++ b/metadata/src/lib.rs
@@ -291,10 +291,10 @@ impl Metadata for Playlist {
             .get_contents()
             .get_items()
             .iter()
-            .map(|item| {
+            .filter_map(|item| {
                 let uri_split = item.get_uri().split(':');
                 let uri_parts: Vec<&str> = uri_split.collect();
-                SpotifyId::from_base62(uri_parts[2]).unwrap()
+                SpotifyId::from_base62(uri_parts[2]).ok()
             })
             .collect::<Vec<_>>();
<!-- gh-comment-id:920774614 --> @ashthespy commented on GitHub (Sep 16, 2021): Try looking at [`filter_map`](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.filter_map) :-) Something like this should be sufficient.. (please do test though!) ```diff diff --git a/metadata/src/lib.rs b/metadata/src/lib.rs index cf663ce6..2ed9273e 100644 --- a/metadata/src/lib.rs +++ b/metadata/src/lib.rs @@ -291,10 +291,10 @@ impl Metadata for Playlist { .get_contents() .get_items() .iter() - .map(|item| { + .filter_map(|item| { let uri_split = item.get_uri().split(':'); let uri_parts: Vec<&str> = uri_split.collect(); - SpotifyId::from_base62(uri_parts[2]).unwrap() + SpotifyId::from_base62(uri_parts[2]).ok() }) .collect::<Vec<_>>(); ```
kerem commented 2026-02-27 19:30:33 +03:00
Author
Owner
Copy link

@RainbowCookie32 commented on GitHub (Sep 16, 2021):

I knew there had to be a nicer way 😅

Seems to work fine, will PR it. Thanks for the help guys!

<!-- gh-comment-id:921040583 --> @RainbowCookie32 commented on GitHub (Sep 16, 2021): I knew there had to be a nicer way 😅 Seems to work fine, will PR it. Thanks for the help guys!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
v0.8.0
v0.7.1
v0.7.0
v0.6.0
v0.5.0
v0.4.2
v0.4.1
v0.4.0
v0.3.1
v0.3.0
v0.2.0
v0.1.6
v0.1.5
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
A-Alsa

   
SpotifyAPI

   
Tokio 1.0

   
audio

   
bug

   
can't reproduce

   
compilation

   
dependencies

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
high priority

   
imported

   
imported

   
invalid

   
new api

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
reverse engineering

   
wiki

   
wontfix
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#424
No description provided.