[PR #424] [CLOSED] WIP: Futures03 #918

New issue

Closed

opened 2026-02-27 20:00:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/424
Author: @marcelbuesing
Created: 1/17/2020
Status: ❌ Closed

Base: dev ← Head: futures03

📝 Commits (2)

76ece26 Bump protobuf v2.8.1 -> v~2.14.0 and fix build issues
07518ef Start migration

📊 Changes

35 files changed (+2279 additions, -2726 deletions)

View changed files

📝 Cargo.lock (+1141 -788)
📝 Cargo.toml (+1 -1)
📝 audio/Cargo.toml (+2 -1)
📝 audio/src/fetch.rs (+57 -59)
📝 audio/src/lib.rs (+0 -15)
📝 connect/Cargo.toml (+1 -1)
➕ core/.vscode/settings.json (+3 -0)
📝 core/Cargo.toml (+16 -7)
📝 core/src/apresolve.rs (+47 -50)
📝 core/src/audio_key.rs (+8 -9)
📝 core/src/channel.rs (+32 -31)
📝 core/src/connection/codec.rs (+2 -3)
📝 core/src/connection/handshake.rs (+46 -37)
📝 core/src/connection/mod.rs (+63 -67)
📝 core/src/keymaster.rs (+1 -1)
📝 core/src/lib.rs (+0 -24)
📝 core/src/mercury/mod.rs (+34 -34)
📝 core/src/mercury/sender.rs (+25 -9)
📝 core/src/proxytunnel.rs (+26 -20)
📝 core/src/session.rs (+28 -26)

...and 15 more files

📄 Description

Based on #423

I started migrating the audio and core crates to futures 0.3, tokio 0.2, hyper 0.13 ... There is still quite a lot left to do. I think the remaining crates could then first use futures compat and then be migrated one by one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/424 **Author:** [@marcelbuesing](https://github.com/marcelbuesing) **Created:** 1/17/2020 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `futures03` --- ### 📝 Commits (2) - [`76ece26`](https://github.com/librespot-org/librespot/commit/76ece26aa4d5a21132393264302c84765fa4998e) Bump protobuf v2.8.1 -> v~2.14.0 and fix build issues - [`07518ef`](https://github.com/librespot-org/librespot/commit/07518ef30f773f835f2f691b2820c31f1e332ea7) Start migration ### 📊 Changes **35 files changed** (+2279 additions, -2726 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1141 -788) 📝 `Cargo.toml` (+1 -1) 📝 `audio/Cargo.toml` (+2 -1) 📝 `audio/src/fetch.rs` (+57 -59) 📝 `audio/src/lib.rs` (+0 -15) 📝 `connect/Cargo.toml` (+1 -1) ➕ `core/.vscode/settings.json` (+3 -0) 📝 `core/Cargo.toml` (+16 -7) 📝 `core/src/apresolve.rs` (+47 -50) 📝 `core/src/audio_key.rs` (+8 -9) 📝 `core/src/channel.rs` (+32 -31) 📝 `core/src/connection/codec.rs` (+2 -3) 📝 `core/src/connection/handshake.rs` (+46 -37) 📝 `core/src/connection/mod.rs` (+63 -67) 📝 `core/src/keymaster.rs` (+1 -1) 📝 `core/src/lib.rs` (+0 -24) 📝 `core/src/mercury/mod.rs` (+34 -34) 📝 `core/src/mercury/sender.rs` (+25 -9) 📝 `core/src/proxytunnel.rs` (+26 -20) 📝 `core/src/session.rs` (+28 -26) _...and 15 more files_ </details> ### 📄 Description Based on #423 I started migrating the audio and core crates to futures 0.3, tokio 0.2, hyper 0.13 ... There is still quite a lot left to do. I think the remaining crates could then first use futures compat and then be migrated one by one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:27 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#918

No description provided.

Rows
Columns