[PR #239] [MERGED] Replace rust-crypto crate with RustCrypto crates #845

New issue

Closed

opened 2026-02-27 20:00:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/239
Author: @newpavlov
Created: 7/23/2018
Status: ✅ Merged
Merged: 3/20/2019
Merged by: @sashahilton00

Base: master ← Head: master

📝 Commits (10+)

e467702 replace rust-crypto's hashes, HMAC and PBKDF2
1f1cd11 aes-ctr
2ae5589 bump min Rust version to 1.27
0626655 update dependencies
7725915 Merge branch 'master' into master
5706562 update deps
4bd0fc8 update aes-ctr to 0.3
54974d8 update Cargo.lock
391b9c6 Merge branch 'master' into master
7258944 update Cargo.lock, use constant time equality check, remove block-modes

📊 Changes

15 files changed (+335 additions, -139 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 Cargo.lock (+230 -24)
📝 Cargo.toml (+2 -4)
📝 audio/Cargo.toml (+1 -1)
📝 audio/src/decrypt.rs (+19 -28)
📝 audio/src/lib.rs (+1 -1)
📝 connect/Cargo.toml (+4 -1)
📝 connect/src/discovery.rs (+25 -25)
📝 connect/src/lib.rs (+5 -1)
📝 core/Cargo.toml (+4 -1)
📝 core/src/authentication.rs (+27 -37)
📝 core/src/connection/handshake.rs (+8 -7)
📝 core/src/lib.rs (+4 -1)
📝 src/lib.rs (+0 -1)
📝 src/main.rs (+4 -6)

📄 Description

As was discussed in the #128. Currently this PR lacks only AES-CTR in audio/src/decrypt.rs and connect/src/discovery.rs, which will require some work on RustCrypto side.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/239 **Author:** [@newpavlov](https://github.com/newpavlov) **Created:** 7/23/2018 **Status:** ✅ Merged **Merged:** 3/20/2019 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`e467702`](https://github.com/librespot-org/librespot/commit/e4677027d24bdffdeec428e95816ab4c9ecf6565) replace rust-crypto's hashes, HMAC and PBKDF2 - [`1f1cd11`](https://github.com/librespot-org/librespot/commit/1f1cd116e7767579da0c2949347f15b59ae30d1c) aes-ctr - [`2ae5589`](https://github.com/librespot-org/librespot/commit/2ae558931818a34f1c024b318063cfc59e0f9772) bump min Rust version to 1.27 - [`0626655`](https://github.com/librespot-org/librespot/commit/06266556deb6ede80cccf1354f263891e81379b1) update dependencies - [`7725915`](https://github.com/librespot-org/librespot/commit/772591576ad49b605c4166e5b4a86d4e16e1cc0f) Merge branch 'master' into master - [`5706562`](https://github.com/librespot-org/librespot/commit/57065620ef99a2976c0373cc5786da7549c36668) update deps - [`4bd0fc8`](https://github.com/librespot-org/librespot/commit/4bd0fc8b36ad7335942c99db25d12261ba230381) update aes-ctr to 0.3 - [`54974d8`](https://github.com/librespot-org/librespot/commit/54974d8bd085c0d92d42c9e562db78a43c73a33c) update Cargo.lock - [`391b9c6`](https://github.com/librespot-org/librespot/commit/391b9c69c4a3bda51e25c93b373f8ca4d96163bc) Merge branch 'master' into master - [`7258944`](https://github.com/librespot-org/librespot/commit/72589443c762b134d5cac10d264bce94e2cac5e2) update Cargo.lock, use constant time equality check, remove block-modes ### 📊 Changes **15 files changed** (+335 additions, -139 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `Cargo.lock` (+230 -24) 📝 `Cargo.toml` (+2 -4) 📝 `audio/Cargo.toml` (+1 -1) 📝 `audio/src/decrypt.rs` (+19 -28) 📝 `audio/src/lib.rs` (+1 -1) 📝 `connect/Cargo.toml` (+4 -1) 📝 `connect/src/discovery.rs` (+25 -25) 📝 `connect/src/lib.rs` (+5 -1) 📝 `core/Cargo.toml` (+4 -1) 📝 `core/src/authentication.rs` (+27 -37) 📝 `core/src/connection/handshake.rs` (+8 -7) 📝 `core/src/lib.rs` (+4 -1) 📝 `src/lib.rs` (+0 -1) 📝 `src/main.rs` (+4 -6) </details> ### 📄 Description As was discussed in the #128. Currently this PR lacks only AES-CTR in `audio/src/decrypt.rs` and `connect/src/discovery.rs`, which will require some work on RustCrypto side. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:11 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:12 +03:00

[PR #846] [MERGED] metadata: avoid unwrapping when parsing a playlist #1112

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#845

No description provided.

Rows
Columns