[PR #1246] [CLOSED] Obtain spclient access token using login5 instead of keymaster (Fixes #1179 and #1245) #1299

New issue

Closed

opened 2026-02-27 20:01:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1246
Author: @lmore377
Created: 1/19/2024
Status: ❌ Closed

Base: dev ← Head: auth-token-from-login5-lmore377

📝 Commits (10+)

96e02fd Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)
ba08273 Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)
f065908 Merge branch 'librespot-org:dev' into auth-token-from-login5
a54cc8f Merge branch 'librespot-org:dev' into auth-token-from-login5
f815318 Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)
40c2a4d Merge branch 'librespot-org:dev' into auth-token-from-login5
87dddf2 Merge branch 'auth-token-from-login5' of https://github.com/Gerrelt/librespot into auth-token-from-login5
726ebec Bump zerocopy from 0.7.26 to 0.7.31
3dde1ca Replace the apparently unmaintained hex crate with data-encoding
9101eeb spclient: improve token request logging

📊 Changes

3 files changed (+109 additions, -6 deletions)

View changed files

📝 core/src/session.rs (+10 -0)
📝 core/src/spclient.rs (+92 -6)
📝 protocol/build.rs (+7 -0)

📄 Description

This PR is a copy of #1220 as that one seems stale. This resolves the issue where authentication fails when spotify connect is started from a desktop client.

Fixes #1179 and #1245. Tested and works with clients from Android, iOS, Windows, Linux and macOS.

I still need to resolve the review comments from #1220, I'm just opening this now to keep track of changes.
I'm very inexperienced when it comes to rust so please be gentle 😆

Credits:
@kingosticks - Created the initial branch with the fix
@Gerrelt - Created the PR that this one is based on

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1246 **Author:** [@lmore377](https://github.com/lmore377) **Created:** 1/19/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `auth-token-from-login5-lmore377` --- ### 📝 Commits (10+) - [`96e02fd`](https://github.com/librespot-org/librespot/commit/96e02fd117b428e0652c1562852ed3d49417fa5b) Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179) - [`ba08273`](https://github.com/librespot-org/librespot/commit/ba08273dd0296ea593b16de0847ae9a89c62447e) Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179) - [`f065908`](https://github.com/librespot-org/librespot/commit/f0659083105aa51fef4df26c416a1dde1b1a08ff) Merge branch 'librespot-org:dev' into auth-token-from-login5 - [`a54cc8f`](https://github.com/librespot-org/librespot/commit/a54cc8f5cd63147e9482425fc45a0c04b5d7a1d5) Merge branch 'librespot-org:dev' into auth-token-from-login5 - [`f815318`](https://github.com/librespot-org/librespot/commit/f81531836f4bd1f9abe299006818d13ae6ec20a8) Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179) - [`40c2a4d`](https://github.com/librespot-org/librespot/commit/40c2a4da163bf598aabae2c028f0b733bc77bb56) Merge branch 'librespot-org:dev' into auth-token-from-login5 - [`87dddf2`](https://github.com/librespot-org/librespot/commit/87dddf2f0aa33f4de425212641b1bef87bbe3532) Merge branch 'auth-token-from-login5' of https://github.com/Gerrelt/librespot into auth-token-from-login5 - [`726ebec`](https://github.com/librespot-org/librespot/commit/726ebec8a4b4e52caca36aa946142de54e3b1092) Bump zerocopy from 0.7.26 to 0.7.31 - [`3dde1ca`](https://github.com/librespot-org/librespot/commit/3dde1ca67a6ddaeda9d5387c09ee11b8ab7ab2f2) Replace the apparently unmaintained hex crate with data-encoding - [`9101eeb`](https://github.com/librespot-org/librespot/commit/9101eebc997125b8d37e1ae51e5a4ec97e378b5c) spclient: improve token request logging ### 📊 Changes **3 files changed** (+109 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `core/src/session.rs` (+10 -0) 📝 `core/src/spclient.rs` (+92 -6) 📝 `protocol/build.rs` (+7 -0) </details> ### 📄 Description This PR is a copy of #1220 as that one seems stale. This resolves the issue where authentication fails when spotify connect is started from a desktop client. Fixes #1179 and #1245. Tested and works with clients from Android, iOS, Windows, Linux and macOS. I still need to resolve the review comments from #1220, I'm just opening this now to keep track of changes. I'm very inexperienced when it comes to rust so please be gentle 😆 Credits: @kingosticks - Created the initial branch with the fix @Gerrelt - Created the PR that this one is based on --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:55 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:01 +03:00

[PR #1299] [MERGED] Docker cross compile - remove MIPS target platform #1325

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1299

No description provided.

Rows
Columns