[PR #1140] [MERGED] Remove and update dependencies #1245

New issue

Closed

opened 2026-02-27 20:01:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1140
Author: @yubiuser
Created: 4/1/2023
Status: ✅ Merged
Merged: 4/11/2023
Merged by: @roderickvd

Base: dev ← Head: remove_dependencies

📝 Commits (10+)

8561206 Remove unused dependencies
fe9012a Update dependencies
f3a18a3 Increase MSRV
cd1f16e Handle result
d2ad386 Fix gstreamer.rs
c18da0b Bump MSRV to 1.64
1e4c324 Fix passthrough_decoders.rs after changes in https://github.com/RustAudio/ogg/pull/25
f4ec772 Fix clippy
379c127 Use pbkdf2_hmac
2fa354c Remove .to_vec()

📊 Changes

10 files changed (+693 additions, -689 deletions)

View changed files

📝 .github/workflows/test.yml (+3 -3)
📝 Cargo.lock (+663 -657)
📝 Cargo.toml (+1 -1)
📝 core/Cargo.toml (+4 -5)
📝 core/src/authentication.rs (+2 -3)
📝 playback/Cargo.toml (+6 -6)
📝 playback/src/audio_backend/gstreamer.rs (+2 -1)
📝 playback/src/decoder/passthrough_decoder.rs (+8 -8)
📝 playback/src/decoder/symphonia_decoder.rs (+4 -4)
📝 protocol/Cargo.toml (+0 -1)

📄 Description

I used cargo-udeps from here to scan for unused dependencies. Two package were removed, num and glob.
With cargo upgrades from here I scanned for upgradable dependencies in the Cagro.toml files. I updated them (and regenerated the Cargo.lock) execept of

librespot-core: /core/Cargo.toml
	base64 matches 0.13.1;	latest is 0.21.0
	quick-xml matches 0.23.1;	latest is 0.28.1
	rsa matches 0.6.1;	latest is 0.8.2
	vergen matches 7.5.1;	latest is 8.1.0

librespot-discovery: /discovery/Cargo.toml
	base64 matches 0.13.1;	latest is 0.21.0

because they require changes to the code beyond my rust knowledge. I tracked them down as far as I could - hopefully someone else can continue here:

vergen does not have thevergen::Config structure since 8.0 anymore, but uses vergen::EmitBuilder now.
rsa does not have the hash module anymore since 0.7.0, but uses OIDs
base64 changed encode* and decode* top level functions to methods of engine since 0.20
quick-xml failed with a few compiling errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1140 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 4/1/2023 **Status:** ✅ Merged **Merged:** 4/11/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `remove_dependencies` --- ### 📝 Commits (10+) - [`8561206`](https://github.com/librespot-org/librespot/commit/8561206b576a21cc79f323df72134aed35967b1f) Remove unused dependencies - [`fe9012a`](https://github.com/librespot-org/librespot/commit/fe9012abf862d8d6f6a67ecccaeb96d69a6d1ccf) Update dependencies - [`f3a18a3`](https://github.com/librespot-org/librespot/commit/f3a18a3a966e8aba9abb2db20788106db85965e7) Increase MSRV - [`cd1f16e`](https://github.com/librespot-org/librespot/commit/cd1f16e4e675a682d0aa41b54e2221ba1cbd7502) Handle result - [`d2ad386`](https://github.com/librespot-org/librespot/commit/d2ad3861340c849c7ffe2b399767d0bc9fa933bd) Fix gstreamer.rs - [`c18da0b`](https://github.com/librespot-org/librespot/commit/c18da0bf89aa8a0856a9a3c12827683be5c98854) Bump MSRV to 1.64 - [`1e4c324`](https://github.com/librespot-org/librespot/commit/1e4c32489c6e8e5b75cee884b17b5e06ff34e91f) Fix passthrough_decoders.rs after changes in https://github.com/RustAudio/ogg/pull/25 - [`f4ec772`](https://github.com/librespot-org/librespot/commit/f4ec772d6127f3cc9f9dcd23efe9d06237b456bf) Fix clippy - [`379c127`](https://github.com/librespot-org/librespot/commit/379c127ad2988318c745a39d7fc0039c78127543) Use pbkdf2_hmac - [`2fa354c`](https://github.com/librespot-org/librespot/commit/2fa354cd7b1b01e43920de9bd23c8f0d175f94eb) Remove .to_vec() ### 📊 Changes **10 files changed** (+693 additions, -689 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+3 -3) 📝 `Cargo.lock` (+663 -657) 📝 `Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+4 -5) 📝 `core/src/authentication.rs` (+2 -3) 📝 `playback/Cargo.toml` (+6 -6) 📝 `playback/src/audio_backend/gstreamer.rs` (+2 -1) 📝 `playback/src/decoder/passthrough_decoder.rs` (+8 -8) 📝 `playback/src/decoder/symphonia_decoder.rs` (+4 -4) 📝 `protocol/Cargo.toml` (+0 -1) </details> ### 📄 Description I used `cargo-udeps` from [here](https://github.com/est31/cargo-udeps) to scan for unused dependencies. Two package were removed, `num` and `glob`. With `cargo upgrades` from [here](https://crates.io/crates/cargo-upgrades) I scanned for upgradable dependencies in the `Cagro.toml` files. I updated them (and regenerated the `Cargo.lock`) execept of ``` librespot-core: /core/Cargo.toml base64 matches 0.13.1; latest is 0.21.0 quick-xml matches 0.23.1; latest is 0.28.1 rsa matches 0.6.1; latest is 0.8.2 vergen matches 7.5.1; latest is 8.1.0 librespot-discovery: /discovery/Cargo.toml base64 matches 0.13.1; latest is 0.21.0 ``` because they require changes to the code beyond my rust knowledge. I tracked them down as far as I could - hopefully someone else can continue here: - `vergen` does not have the`vergen::Config` [structure](https://docs.rs/vergen/7.4.2/vergen/struct.Config.html) [since 8.0](https://github.com/rustyhorde/vergen/pull/146) anymore, but uses `vergen::EmitBuilder` [now](https://docs.rs/vergen/8.1.0/vergen/struct.EmitBuilder.html). - `rsa` does not have the `hash` module [anymore](https://github.com/RustCrypto/RSA/blob/master/CHANGELOG.md#removed) since 0.7.0, but uses `OIDs` - `base64` changed `encode*` and `decode*` top level functions to methods of `engine` [since 0.20](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md#breaking-changes-1) - `quick-xml` failed with a few compiling errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:43 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:55 +03:00

[PR #1246] [CLOSED] Obtain spclient access token using login5 instead of keymaster (Fixes #1179 and #1245) #1299

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1245

No description provided.

Rows
Columns