[PR #1299] [MERGED] Docker cross compile - remove MIPS target platform #1325

New issue

Closed

opened 2026-02-27 20:02:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1299
Author: @starypatyk
Created: 6/11/2024
Status: ✅ Merged
Merged: 6/11/2024
Merged by: @roderickvd

Base: dev ← Head: docker-remove-mips

📝 Commits (1)

4f8a84e Docker cross compile - remove MIPS target platform

📊 Changes

2 files changed (+4 additions, -9 deletions)

View changed files

📝 contrib/Dockerfile (+4 -8)
📝 contrib/docker-build.sh (+0 -1)

📄 Description

Follow up to #1297 and #1298

Given that:

MSRV was moved up to 1.73.
Even with rust 1.71 the MIPS target did not build successfully.
Apparently there is hardly any interest in maintaining the MIPS platform.
Last but not least - the Docker image for cross-compilation did not build - since MIPS target was demoted to tier 3 at 1.72.

I propose to remove the MIPS architecture entirely from the Docker image for cross compilation.

After these changes, I was able to:

Build the Docker image.
Cross compile for all remaining platforms.
Verify that x86_64 and aarch64 binaries work fine on Ubuntu 22.04 (regular PC) and Raspberry PI OS (64-bit/bookworm/Raspberry Pi 3) respectively.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1299 **Author:** [@starypatyk](https://github.com/starypatyk) **Created:** 6/11/2024 **Status:** ✅ Merged **Merged:** 6/11/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `docker-remove-mips` --- ### 📝 Commits (1) - [`4f8a84e`](https://github.com/librespot-org/librespot/commit/4f8a84e7cb3f257bb4ca185e10ec9bd3cc7b1bbf) Docker cross compile - remove MIPS target platform ### 📊 Changes **2 files changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `contrib/Dockerfile` (+4 -8) 📝 `contrib/docker-build.sh` (+0 -1) </details> ### 📄 Description Follow up to #1297 and #1298 Given that: - MSRV was moved up to 1.73. - Even with rust 1.71 the MIPS target did not build successfully. - Apparently there is hardly any interest in maintaining the MIPS platform. - Last but not least - the Docker image for cross-compilation did not build - since MIPS target was demoted to tier 3 at 1.72. I propose to remove the **MIPS** architecture entirely from the Docker image for cross compilation. After these changes, I was able to: - Build the Docker image. - Cross compile for all remaining platforms. - Verify that **x86_64** and **aarch64** binaries work fine on Ubuntu 22.04 (regular PC) and Raspberry PI OS (64-bit/bookworm/Raspberry Pi 3) respectively. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:01 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:10 +03:00

[PR #1373] [MERGED] Fix initial volume showing zero but playing full volume #1366

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1325

No description provided.

Rows
Columns