[PR #1230] [MERGED] Cargo replace hex with data-encoding #1292

New issue

Closed

opened 2026-02-27 20:01:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1230
Author: @dsheets
Created: 12/6/2023
Status: ✅ Merged
Merged: 12/15/2023
Merged by: @roderickvd

Base: dev ← Head: cargo-replace-hex-with-data-encoding

📝 Commits (3)

ba314b6 Replace the apparently unmaintained hex crate with data-encoding
29f3345 spclient: improve token request logging
0fbd19b core: make it easier to change declared OS

📊 Changes

6 files changed (+45 additions, -28 deletions)

View changed files

📝 Cargo.lock (+4 -4)
📝 Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 core/src/config.rs (+10 -4)
📝 core/src/spclient.rs (+27 -17)
📝 src/main.rs (+2 -1)

📄 Description

Ok, let's try #1227 again but now with more feeling...

data-encoding was already a transitive dependency of tungstenite so this changeset strictly reduces the dep set of the project.

I've also added some improved logging and made it easier to spoof the OS type by moving the side effect to a single line in spclient and parameterizing the use sites.

I tested the hashcash challenge with "ios" and found I could stream music (but there were other complaints about 502 responses to some requests and sometimes my decrepit machine was too slow to solve the challenge).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1230 **Author:** [@dsheets](https://github.com/dsheets) **Created:** 12/6/2023 **Status:** ✅ Merged **Merged:** 12/15/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `cargo-replace-hex-with-data-encoding` --- ### 📝 Commits (3) - [`ba314b6`](https://github.com/librespot-org/librespot/commit/ba314b63e49ede9a4ee40e1edd281f8532b548f2) Replace the apparently unmaintained hex crate with data-encoding - [`29f3345`](https://github.com/librespot-org/librespot/commit/29f3345030b1ef998e6a1a198e5810d43ca9fe3e) spclient: improve token request logging - [`0fbd19b`](https://github.com/librespot-org/librespot/commit/0fbd19b521b8294eaef4585faebe0c3e1eb6b7d4) core: make it easier to change declared OS ### 📊 Changes **6 files changed** (+45 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+4 -4) 📝 `Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/config.rs` (+10 -4) 📝 `core/src/spclient.rs` (+27 -17) 📝 `src/main.rs` (+2 -1) </details> ### 📄 Description Ok, let's try #1227 again but now with more feeling... `data-encoding` was already a transitive dependency of tungstenite so this changeset strictly reduces the dep set of the project. I've also added some improved logging and made it easier to spoof the OS type by moving the side effect to a single line in `spclient` and parameterizing the use sites. I tested the hashcash challenge with `"ios"` and found I could stream music (but there were other complaints about 502 responses to some requests and sometimes my decrepit machine was too slow to solve the challenge). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1292

No description provided.

Rows
Columns