mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1089] [MERGED] Handle microsecond timestamps #1227
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1227
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1089
Author: @GeorgeHahn
Created: 1/4/2023
Status: ✅ Merged
Merged: 1/4/2023
Merged by: @roderickvd
Base:
dev← Head:microsecond-timestamps📝 Commits (3)
512c799Handle microsecond timestampsc2c3124changelogce4be71fix timestamp heuristic (year 2200+)📊 Changes
2 files changed (+18 additions, -1 deletions)
View changed files
📝
CHANGELOG.md(+1 -0)📝
metadata/src/playlist/list.rs(+17 -1)📄 Description
I've observed that artist mix playlists are being sent with timestamps measured in microseconds. This causes
Date::from_timestamp_msto return an error.Handled with a simple heuristic that will stop working in about two hundred years.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.