[PR #1089] [MERGED] Handle microsecond timestamps #1227

Closed
opened 2026-02-27 20:01:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1089
Author: @GeorgeHahn
Created: 1/4/2023
Status: Merged
Merged: 1/4/2023
Merged by: @roderickvd

Base: devHead: microsecond-timestamps


📝 Commits (3)

📊 Changes

2 files changed (+18 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 metadata/src/playlist/list.rs (+17 -1)

📄 Description

I've observed that artist mix playlists are being sent with timestamps measured in microseconds. This causes Date::from_timestamp_ms to return an error.

Handled with a simple heuristic that will stop working in about two hundred years.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1089 **Author:** [@GeorgeHahn](https://github.com/GeorgeHahn) **Created:** 1/4/2023 **Status:** ✅ Merged **Merged:** 1/4/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `microsecond-timestamps` --- ### 📝 Commits (3) - [`512c799`](https://github.com/librespot-org/librespot/commit/512c79926650ba81902accf3d7c96adaa33ef39c) Handle microsecond timestamps - [`c2c3124`](https://github.com/librespot-org/librespot/commit/c2c31247b559ebcee13539feef0bdae0db569584) changelog - [`ce4be71`](https://github.com/librespot-org/librespot/commit/ce4be7171909d9aec93f58b1f7fe684e3b085827) fix timestamp heuristic (year 2200+) ### 📊 Changes **2 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `metadata/src/playlist/list.rs` (+17 -1) </details> ### 📄 Description I've observed that artist mix playlists are being sent with timestamps measured in microseconds. This causes `Date::from_timestamp_ms` to return an error. Handled with a simple heuristic that will stop working in about two hundred years. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1227
No description provided.