[PR #1092] [MERGED] Update protobuf and related crates to 3.x #1230

New issue

Closed

opened 2026-02-27 20:01:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1092
Author: @tyrylu
Created: 1/7/2023
Status: ✅ Merged
Merged: 1/17/2023
Merged by: @roderickvd

Base: dev ← Head: update_protobuf

📝 Commits (3)

4f6d9da Update protobuf and related crates to 3.x
f3df117 Get rit of unwraps
659559d Run rustmft

📊 Changes

38 files changed (+689 additions, -667 deletions)

View changed files

📝 Cargo.lock (+64 -21)
📝 connect/Cargo.toml (+1 -1)
📝 connect/src/spirc.rs (+172 -244)
📝 core/Cargo.toml (+1 -1)
📝 core/src/authentication.rs (+3 -3)
📝 core/src/cdn_url.rs (+7 -4)
📝 core/src/connection/handshake.rs (+42 -26)
📝 core/src/connection/mod.rs (+19 -11)
📝 core/src/date.rs (+5 -13)
📝 core/src/error.rs (+1 -1)
📝 core/src/file_id.rs (+3 -3)
📝 core/src/mercury/mod.rs (+2 -2)
📝 core/src/spclient.rs (+47 -44)
📝 core/src/spotify_id.rs (+12 -12)
📝 metadata/Cargo.toml (+1 -1)
📝 metadata/src/album.rs (+24 -24)
📝 metadata/src/artist.rs (+36 -31)
📝 metadata/src/audio/file.rs (+4 -4)
📝 metadata/src/availability.rs (+3 -3)
📝 metadata/src/content_rating.rs (+2 -2)

...and 18 more files

📄 Description

This PR updates protobuf to 3.x.
To do that, it also replaces protobuf-codegen-pure 2.x with protobuf-codegen 3.x, which has the same capabilities. This version of the generated protocol API has a slightly different API, so the PR looks larger than it actually is.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1092 **Author:** [@tyrylu](https://github.com/tyrylu) **Created:** 1/7/2023 **Status:** ✅ Merged **Merged:** 1/17/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `update_protobuf` --- ### 📝 Commits (3) - [`4f6d9da`](https://github.com/librespot-org/librespot/commit/4f6d9dacb4af9589dc3c16d40bad1f24f2ab888a) Update protobuf and related crates to 3.x - [`f3df117`](https://github.com/librespot-org/librespot/commit/f3df117db6fdc322cec645c82d5cd7cec57cd942) Get rit of unwraps - [`659559d`](https://github.com/librespot-org/librespot/commit/659559d2b77bc3dc9b8e8f398b12749ca9157954) Run rustmft ### 📊 Changes **38 files changed** (+689 additions, -667 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+64 -21) 📝 `connect/Cargo.toml` (+1 -1) 📝 `connect/src/spirc.rs` (+172 -244) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/authentication.rs` (+3 -3) 📝 `core/src/cdn_url.rs` (+7 -4) 📝 `core/src/connection/handshake.rs` (+42 -26) 📝 `core/src/connection/mod.rs` (+19 -11) 📝 `core/src/date.rs` (+5 -13) 📝 `core/src/error.rs` (+1 -1) 📝 `core/src/file_id.rs` (+3 -3) 📝 `core/src/mercury/mod.rs` (+2 -2) 📝 `core/src/spclient.rs` (+47 -44) 📝 `core/src/spotify_id.rs` (+12 -12) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `metadata/src/album.rs` (+24 -24) 📝 `metadata/src/artist.rs` (+36 -31) 📝 `metadata/src/audio/file.rs` (+4 -4) 📝 `metadata/src/availability.rs` (+3 -3) 📝 `metadata/src/content_rating.rs` (+2 -2) _...and 18 more files_ </details> ### 📄 Description This PR updates protobuf to 3.x. To do that, it also replaces protobuf-codegen-pure 2.x with protobuf-codegen 3.x, which has the same capabilities. This version of the generated protocol API has a slightly different API, so the PR looks larger than it actually is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:40 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:53 +03:00

[PR #1230] [MERGED] Cargo replace hex with data-encoding #1292

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1230

No description provided.

Rows
Columns