[PR #1066] [MERGED] core: workaround for Session::connect() future being !Send #1216

New issue

Closed

opened 2026-02-27 20:01:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1066
Author: @gdesmott
Created: 10/20/2022
Status: ✅ Merged
Merged: 10/26/2022
Merged by: @roderickvd

Base: dev ← Head: send-workaround

📝 Commits (1)

1a48bc8 core: workaround for Session::connect() future being !Send

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 core/src/connection/handshake.rs (+11 -2)

📄 Description

rsa::padding::PaddingScheme is !Send, making it impossible to call Session::connect() with an executor requiring Send futures, such as Rocket.

Fix #1065

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1066 **Author:** [@gdesmott](https://github.com/gdesmott) **Created:** 10/20/2022 **Status:** ✅ Merged **Merged:** 10/26/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `send-workaround` --- ### 📝 Commits (1) - [`1a48bc8`](https://github.com/librespot-org/librespot/commit/1a48bc87c879201b534b34e1995bd501d02f32ef) core: workaround for Session::connect() future being !Send ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `core/src/connection/handshake.rs` (+11 -2) </details> ### 📄 Description rsa::padding::PaddingScheme is !Send, making it impossible to call Session::connect() with an executor requiring Send futures, such as Rocket. Fix #1065 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:51 +03:00

[PR #1216] [MERGED] fix clippy errors #1280

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1216

No description provided.

Rows
Columns