[PR #762] [MERGED] Mostly cosmetic changes in `dealer` #1066

New issue

Closed

opened 2026-02-27 20:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/762
Author: @Johannesd3
Created: 5/26/2021
Status: ✅ Merged
Merged: 5/27/2021
Merged by: @Johannesd3

Base: new-api ← Head: new-api

📝 Commits (2)

9921f81 Add missing timeout on reconnect
02c9441 Cosmetic changes

📊 Changes

2 files changed (+47 additions, -43 deletions)

View changed files

📝 core/src/dealer/mod.rs (+33 -29)
📝 core/src/dealer/protocol.rs (+14 -14)

📄 Description

Added sleep before next reconnection try.
Use constants for durations.
Removed generic parameter of message and request, which were a relict of gzip support.
Implement Error for the errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/762 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 5/26/2021 **Status:** ✅ Merged **Merged:** 5/27/2021 **Merged by:** [@Johannesd3](https://github.com/Johannesd3) **Base:** `new-api` ← **Head:** `new-api` --- ### 📝 Commits (2) - [`9921f81`](https://github.com/librespot-org/librespot/commit/9921f819f4b4c5c8e85202da50ed5bc071bf0fc4) Add missing timeout on reconnect - [`02c9441`](https://github.com/librespot-org/librespot/commit/02c9441fdeb44588df0a9ba69a782340cab9e69e) Cosmetic changes ### 📊 Changes **2 files changed** (+47 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `core/src/dealer/mod.rs` (+33 -29) 📝 `core/src/dealer/protocol.rs` (+14 -14) </details> ### 📄 Description * Added sleep before next reconnection try. * Use constants for durations. * Removed generic parameter of message and request, which were a relict of gzip support. * Implement `Error` for the errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:02 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:36 +03:00

[PR #1066] [MERGED] core: workaround for Session::connect() future being !Send #1216

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1066

No description provided.

Rows
Columns

[PR #762] [MERGED] Mostly cosmetic changes in dealer #1066

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #762] [MERGED] Mostly cosmetic changes in `dealer` #1066