[PR #763] [MERGED] Adjust arg types of `Credentials::with_blob` #1065

New issue

Closed

opened 2026-02-27 20:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/763
Author: @Johannesd3
Created: 5/26/2021
Status: ✅ Merged
Merged: 6/28/2021
Merged by: @roderickvd

Base: dev ← Head: credentials-with-blob-args

📝 Commits (1)

14c1779 Adjust arg types of Credentials::with_blob

📊 Changes

2 files changed (+13 additions, -8 deletions)

View changed files

📝 core/src/authentication.rs (+11 -5)
📝 discovery/src/server.rs (+2 -3)

📄 Description

... to avoid redundant utf-8 checking

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/763 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 5/26/2021 **Status:** ✅ Merged **Merged:** 6/28/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `credentials-with-blob-args` --- ### 📝 Commits (1) - [`14c1779`](https://github.com/librespot-org/librespot/commit/14c177905608f98eb528fae3a66debc3592c79d3) Adjust arg types of `Credentials::with_blob` ### 📊 Changes **2 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `core/src/authentication.rs` (+11 -5) 📝 `discovery/src/server.rs` (+2 -3) </details> ### 📄 Description ... to avoid redundant utf-8 checking --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:02 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:36 +03:00

[PR #1066] [MERGED] core: workaround for Session::connect() future being !Send #1216

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1065

No description provided.

Rows
Columns

[PR #763] [MERGED] Adjust arg types of Credentials::with_blob #1065

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #763] [MERGED] Adjust arg types of `Credentials::with_blob` #1065