mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#954
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/506
Author: @LaurentLouf
Created: 7/25/2020
Status: ✅ Merged
Merged: 1/2/2021
Merged by: @sashahilton00
Base:
dev← Head:feature-split_cache_folders📝 Commits (5)
8fc9ebfAdd the option to specify the system cache for credentials and volume files and adapt Cache to use two cache directories instead of one77cb66dFix syntax09bebe5Fix typesc14c254Formatb340326Don't create directories for the audio cache if it disabled📊 Changes
2 files changed (+32 additions, -12 deletions)
View changed files
📝
core/src/cache.rs(+17 -9)📝
src/main.rs(+15 -3)📄 Description
Cache split for system files (credentials and volume) and audio files. Retro-compatible by making the system cache the same as the audio cache if the option is not specified.
I kept the same directory tree for the audio cache by keeping the
filesdirectory, might not be needed.Use case for this new option : splitting the cache into two : audio cache in a temporary directory, for example a
tmpfsin RAM to minimize writes to the SD card when used on a Raspberry, but system cache in a "permanent" directory, to be available across reboots. Even on a normal PC, you may want to use the HDD for the audio cache and the SSD for system cache to minimize the number of writes on your SSD.Happy to change anything if needed, this is my first time writing some Rust
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.