[PR #851] [MERGED] Add Google sign in credential to protobufs #1113

New issue

Closed

opened 2026-02-27 20:01:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/851
Author: @nick-botticelli
Created: 9/21/2021
Status: ✅ Merged
Merged: 9/21/2021
Merged by: @roderickvd

Base: new-api ← Head: google-signin-credentials

📝 Commits (1)

69c2ad1 Add Google sign in credential to protobufs

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 protocol/proto/spotify/login5/v3/credentials/credentials.proto (+5 -0)
📝 protocol/proto/spotify/login5/v3/login5.proto (+1 -0)

📄 Description

Is there any reason Google sign in credential was excluded from the protobufs? The Google sign in definition was taken from Spotify 1.1.68.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/851 **Author:** [@nick-botticelli](https://github.com/nick-botticelli) **Created:** 9/21/2021 **Status:** ✅ Merged **Merged:** 9/21/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `new-api` ← **Head:** `google-signin-credentials` --- ### 📝 Commits (1) - [`69c2ad1`](https://github.com/librespot-org/librespot/commit/69c2ad1387e9a47ae37e08342c10f10879f2a1f0) Add Google sign in credential to protobufs ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `protocol/proto/spotify/login5/v3/credentials/credentials.proto` (+5 -0) 📝 `protocol/proto/spotify/login5/v3/login5.proto` (+1 -0) </details> ### 📄 Description Is there any reason Google sign in credential was excluded from the protobufs? The Google sign in definition was taken from Spotify 1.1.68. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:41 +03:00

[PR #1113] [MERGED] Fix newly reported clippy errors #1238

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1113

No description provided.

Rows
Columns