[PR #251] [MERGED] Update protobuf #851

New issue

Closed

opened 2026-02-27 20:00:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/251
Author: @ashthespy
Created: 9/26/2018
Status: ✅ Merged
Merged: 10/31/2018
Merged by: @sashahilton00

Base: master ← Head: master

📝 Commits (2)

37c588d Set proper name for kUnknown enum
c5fcdfd Upgrade protobuf to 2.0 and use protoc-rust to compile proto files

📊 Changes

16 files changed (+3391 additions, -7898 deletions)

View changed files

📝 Cargo.lock (+60 -4)
📝 connect/Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 core/src/connection/handshake.rs (+4 -4)
📝 metadata/Cargo.toml (+1 -1)
📝 metadata/src/lib.rs (+1 -1)
📝 protocol/Cargo.toml (+4 -1)
📝 protocol/build.rs (+22 -1)
📝 protocol/files.rs (+2 -2)
📝 protocol/proto/spirc.proto (+1 -1)
📝 protocol/src/authentication.rs (+706 -1681)
📝 protocol/src/keyexchange.rs (+942 -2057)
📝 protocol/src/mercury.rs (+228 -544)
📝 protocol/src/metadata.rs (+825 -1976)
📝 protocol/src/pubsub.rs (+35 -84)
📝 protocol/src/spirc.rs (+558 -1539)

📄 Description

Was digging around and found the right name for it - kSupportsExternalEpisodes

I can't generate the proper files for now however as I can't seem to find a protoc version 2 that I can install and use.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/251 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 9/26/2018 **Status:** ✅ Merged **Merged:** 10/31/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`37c588d`](https://github.com/librespot-org/librespot/commit/37c588d6a172afcf6813cafaeacc1df9347912e1) Set proper name for `kUnknown` enum - [`c5fcdfd`](https://github.com/librespot-org/librespot/commit/c5fcdfd43c45d329a773d0c56e49c78bccee4aaf) Upgrade `protobuf` to `2.0` and use `protoc-rust` to compile proto files ### 📊 Changes **16 files changed** (+3391 additions, -7898 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+60 -4) 📝 `connect/Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/connection/handshake.rs` (+4 -4) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `metadata/src/lib.rs` (+1 -1) 📝 `protocol/Cargo.toml` (+4 -1) 📝 `protocol/build.rs` (+22 -1) 📝 `protocol/files.rs` (+2 -2) 📝 `protocol/proto/spirc.proto` (+1 -1) 📝 `protocol/src/authentication.rs` (+706 -1681) 📝 `protocol/src/keyexchange.rs` (+942 -2057) 📝 `protocol/src/mercury.rs` (+228 -544) 📝 `protocol/src/metadata.rs` (+825 -1976) 📝 `protocol/src/pubsub.rs` (+35 -84) 📝 `protocol/src/spirc.rs` (+558 -1539) </details> ### 📄 Description Was digging around and found the right name for it - `kSupportsExternalEpisodes` I can't generate the proper files for now however as I can't seem to find a `protoc` version 2 that I can install and use. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:12 +03:00

[PR #851] [MERGED] Add Google sign in credential to protobufs #1113

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#851

No description provided.

Rows
Columns