[PR #1113] [MERGED] Fix newly reported clippy errors #1238

Closed
opened 2026-02-27 20:01:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1113
Author: @ptesarik
Created: 1/27/2023
Status: Merged
Merged: 1/28/2023
Merged by: @roderickvd

Base: devHead: clippy


📝 Commits (1)

  • c600297 Fix newly reported clippy errors

📊 Changes

19 files changed (+69 additions, -90 deletions)

View changed files

📝 audio/src/fetch/receive.rs (+2 -2)
📝 audio/src/range_set.rs (+1 -1)
📝 core/build.rs (+1 -1)
📝 core/src/apresolve.rs (+2 -6)
📝 core/src/cache.rs (+2 -2)
📝 core/src/mercury/mod.rs (+1 -1)
📝 core/src/proxytunnel.rs (+1 -1)
📝 core/src/spclient.rs (+12 -19)
📝 metadata/src/request.rs (+3 -3)
📝 playback/src/audio_backend/alsa.rs (+2 -2)
📝 playback/src/audio_backend/gstreamer.rs (+1 -1)
📝 playback/src/audio_backend/jackaudio.rs (+1 -1)
📝 playback/src/audio_backend/portaudio.rs (+5 -5)
📝 playback/src/audio_backend/pulseaudio.rs (+1 -1)
📝 playback/src/audio_backend/rodio.rs (+9 -10)
📝 playback/src/audio_backend/sdl.rs (+1 -1)
📝 playback/src/decoder/passthrough_decoder.rs (+2 -3)
📝 playback/src/decoder/symphonia_decoder.rs (+5 -9)
📝 src/main.rs (+17 -21)

📄 Description

As reported by clippy, variables can be used directly in the format! string.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1113 **Author:** [@ptesarik](https://github.com/ptesarik) **Created:** 1/27/2023 **Status:** ✅ Merged **Merged:** 1/28/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `clippy` --- ### 📝 Commits (1) - [`c600297`](https://github.com/librespot-org/librespot/commit/c600297f52711ab2e9a3b8a2a28d3145c54fff0f) Fix newly reported clippy errors ### 📊 Changes **19 files changed** (+69 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/fetch/receive.rs` (+2 -2) 📝 `audio/src/range_set.rs` (+1 -1) 📝 `core/build.rs` (+1 -1) 📝 `core/src/apresolve.rs` (+2 -6) 📝 `core/src/cache.rs` (+2 -2) 📝 `core/src/mercury/mod.rs` (+1 -1) 📝 `core/src/proxytunnel.rs` (+1 -1) 📝 `core/src/spclient.rs` (+12 -19) 📝 `metadata/src/request.rs` (+3 -3) 📝 `playback/src/audio_backend/alsa.rs` (+2 -2) 📝 `playback/src/audio_backend/gstreamer.rs` (+1 -1) 📝 `playback/src/audio_backend/jackaudio.rs` (+1 -1) 📝 `playback/src/audio_backend/portaudio.rs` (+5 -5) 📝 `playback/src/audio_backend/pulseaudio.rs` (+1 -1) 📝 `playback/src/audio_backend/rodio.rs` (+9 -10) 📝 `playback/src/audio_backend/sdl.rs` (+1 -1) 📝 `playback/src/decoder/passthrough_decoder.rs` (+2 -3) 📝 `playback/src/decoder/symphonia_decoder.rs` (+5 -9) 📝 `src/main.rs` (+17 -21) </details> ### 📄 Description As reported by clippy, variables can be used directly in the `format!` string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1238
No description provided.