[PR #823] [MERGED] Improve player #1100

New issue

Closed

opened 2026-02-27 20:01:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/823
Author: @JasonLG1979
Created: 7/21/2021
Status: ✅ Merged
Merged: 9/20/2021
Merged by: @roderickvd

Base: dev ← Head: improve-player

📝 Commits (9)

711e2d8 Harmonize Seek
ab816b0 Remove unwraps and panics from player
58e544c Reduce duplicate calls
02211d6 Simplify decoder errors with thiserror
2e134d1 Cleanup
51cbb90 Address code reviews
44293a5 Merge branch 'librespot-org:dev' into improve-player
28e5675 Address code reviews 2
1f31527 Address code review

📊 Changes

11 files changed (+280 additions, -242 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 playback/Cargo.toml (+5 -5)
📝 playback/src/audio_backend/jackaudio.rs (+4 -1)
📝 playback/src/audio_backend/portaudio.rs (+4 -1)
📝 playback/src/audio_backend/rodio.rs (+3 -1)
📝 playback/src/audio_backend/sdl.rs (+3 -1)
📝 playback/src/decoder/lewton_decoder.rs (+15 -43)
📝 playback/src/decoder/mod.rs (+31 -38)
📝 playback/src/decoder/passthrough_decoder.rs (+36 -53)
📝 playback/src/lib.rs (+2 -0)
📝 playback/src/player.rs (+176 -98)

📄 Description

Make the decoders and player use the same math for converting between samples and milliseconds.
Remove unwraps, expects and panics from player, decoders and mod.
Reduce redundant math.
Simplify decoder errors with thiserror.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/823 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 7/21/2021 **Status:** ✅ Merged **Merged:** 9/20/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `improve-player` --- ### 📝 Commits (9) - [`711e2d8`](https://github.com/librespot-org/librespot/commit/711e2d8f9b021a8d89d85b383df694a837118a1b) Harmonize Seek - [`ab816b0`](https://github.com/librespot-org/librespot/commit/ab816b042a6ef08dc86c1706b4e9e20e643c0a3a) Remove unwraps and panics from player - [`58e544c`](https://github.com/librespot-org/librespot/commit/58e544c965832c8a2cecf884326ae1bfa365739f) Reduce duplicate calls - [`02211d6`](https://github.com/librespot-org/librespot/commit/02211d6f20beace7a9538e6eeadc0d57fc3867ab) Simplify decoder errors with thiserror - [`2e134d1`](https://github.com/librespot-org/librespot/commit/2e134d1e0977ac26b5568a307f2e25661cf4805f) Cleanup - [`51cbb90`](https://github.com/librespot-org/librespot/commit/51cbb900797062ee29b4bb0196e2f9350a159710) Address code reviews - [`44293a5`](https://github.com/librespot-org/librespot/commit/44293a52751c845a19f4b7a3050d247ba9b9c10c) Merge branch 'librespot-org:dev' into improve-player - [`28e5675`](https://github.com/librespot-org/librespot/commit/28e567589a375be70f07e49b8727e098421c4c24) Address code reviews 2 - [`1f31527`](https://github.com/librespot-org/librespot/commit/1f31527cce49fa2438e6635025beddfeaae0f8c4) Address code review ### 📊 Changes **11 files changed** (+280 additions, -242 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `playback/Cargo.toml` (+5 -5) 📝 `playback/src/audio_backend/jackaudio.rs` (+4 -1) 📝 `playback/src/audio_backend/portaudio.rs` (+4 -1) 📝 `playback/src/audio_backend/rodio.rs` (+3 -1) 📝 `playback/src/audio_backend/sdl.rs` (+3 -1) 📝 `playback/src/decoder/lewton_decoder.rs` (+15 -43) 📝 `playback/src/decoder/mod.rs` (+31 -38) 📝 `playback/src/decoder/passthrough_decoder.rs` (+36 -53) 📝 `playback/src/lib.rs` (+2 -0) 📝 `playback/src/player.rs` (+176 -98) </details> ### 📄 Description * Make the decoders and player use the same math for converting between samples and milliseconds. * Remove unwraps, expects and panics from player, decoders and mod. * Reduce redundant math. * Simplify decoder errors with thiserror. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:40 +03:00

[PR #1100] [CLOSED] [Discovery] Support add user with access token #1232

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1100

No description provided.

Rows
Columns