[PR #1100] [CLOSED] [Discovery] Support add user with access token #1232

New issue

Closed

opened 2026-02-27 20:01:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1100
Author: @GiviMAD
Created: 1/13/2023
Status: ❌ Closed

Base: master ← Head: feature/add_user_with_access_token

📝 Commits (2)

7ddce43 [Discovery] support add user with access token
abbf71d apply fmt

📊 Changes

2 files changed (+70 additions, -52 deletions)

View changed files

📝 core/src/authentication.rs (+8 -0)
📝 discovery/src/server.rs (+62 -52)

📄 Description

Hi,
I have added this changes in order to support adding the client to my account using and access token with the "streaming" scope through the addUser action. It's inspired by the project https://github.com/TimotheeGerber/spotify-connect.

Do you think this can this be merged agains the 0.4.x version and included in the next 0.4.x release? Or is better that I open a pr agains the dev branch?

Hope the code is ok I don't have too much experience with rust.

Regards!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1100 **Author:** [@GiviMAD](https://github.com/GiviMAD) **Created:** 1/13/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/add_user_with_access_token` --- ### 📝 Commits (2) - [`7ddce43`](https://github.com/librespot-org/librespot/commit/7ddce436b1a572d514c50a3c96edae58af04d3e1) [Discovery] support add user with access token - [`abbf71d`](https://github.com/librespot-org/librespot/commit/abbf71d1dd27ce668379979e5cb1d262eee6a4cd) apply fmt ### 📊 Changes **2 files changed** (+70 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `core/src/authentication.rs` (+8 -0) 📝 `discovery/src/server.rs` (+62 -52) </details> ### 📄 Description Hi, I have added this changes in order to support adding the client to my account using and access token with the "streaming" scope through the addUser action. It's inspired by the project https://github.com/TimotheeGerber/spotify-connect. Do you think this can this be merged agains the 0.4.x version and included in the next 0.4.x release? Or is better that I open a pr agains the dev branch? Hope the code is ok I don't have too much experience with rust. Regards! Related to: https://github.com/librespot-org/librespot/issues/1086#issuecomment-1381871262 https://github.com/librespot-org/librespot/pull/1098 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1232

No description provided.

Rows
Columns