[PR #166] [MERGED] API review #823

New issue

Closed

opened 2026-02-27 20:00:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/166
Author: @sashahilton00
Created: 2/25/2018
Status: ✅ Merged
Merged: 2/26/2018
Merged by: @sashahilton00

Base: master ← Head: apireview

📝 Commits (4)

4fb8c71 Set SpotifyId methods to return Result
084646e Use prompt for password in main.rs
0abad9a Add custom SpotifyIdError type
197d80e Fix formatting

📊 Changes

6 files changed (+48 additions, -32 deletions)

View changed files

📝 connect/src/spirc.rs (+1 -1)
📝 core/src/authentication.rs (+8 -9)
📝 core/src/spotify_id.rs (+20 -11)
📝 examples/play.rs (+1 -1)
📝 metadata/src/lib.rs (+9 -9)
📝 src/main.rs (+9 -1)

📄 Description

Last couple of bits to do. I assumed the get_credentials task was a request to move the password reading logic into a seperate function.
SpotifyId methods now return Result, code has been updated and tested.
Have not added the to_raw or from_raw methods to FileId as I'm not sure what the point of doing so is, nor am I familiar with the format of the FileId or what it's used for, and hence will leave that to someone else to do, if even necessary to add.
@plietar this should wrap up #130 as far as I can tell. Are you ok to give the code in the repo a final once over, and if all is good, package it and publish to crates.io?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/166 **Author:** [@sashahilton00](https://github.com/sashahilton00) **Created:** 2/25/2018 **Status:** ✅ Merged **Merged:** 2/26/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `apireview` --- ### 📝 Commits (4) - [`4fb8c71`](https://github.com/librespot-org/librespot/commit/4fb8c71b0a2ca2114f492e445a15a6bd0595dab8) Set SpotifyId methods to return Result - [`084646e`](https://github.com/librespot-org/librespot/commit/084646e21b4ef5ed8abb7a89a44fb03e8ea0e9c8) Use prompt for password in main.rs - [`0abad9a`](https://github.com/librespot-org/librespot/commit/0abad9a8f812103b1a998d25e1a7bfe261c67967) Add custom SpotifyIdError type - [`197d80e`](https://github.com/librespot-org/librespot/commit/197d80edbfc89ef7d72be20b90920b2fbb39961c) Fix formatting ### 📊 Changes **6 files changed** (+48 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+1 -1) 📝 `core/src/authentication.rs` (+8 -9) 📝 `core/src/spotify_id.rs` (+20 -11) 📝 `examples/play.rs` (+1 -1) 📝 `metadata/src/lib.rs` (+9 -9) 📝 `src/main.rs` (+9 -1) </details> ### 📄 Description Last couple of bits to do. I assumed the ```get_credentials``` task was a request to move the password reading logic into a seperate function. SpotifyId methods now return ```Result```, code has been updated and tested. Have not added the to_raw or from_raw methods to FileId as I'm not sure what the point of doing so is, nor am I familiar with the format of the FileId or what it's used for, and hence will leave that to someone else to do, if even necessary to add. @plietar this should wrap up #130 as far as I can tell. Are you ok to give the code in the repo a final once over, and if all is good, package it and publish to crates.io? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:06 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:10 +03:00

[PR #823] [MERGED] Improve player #1100

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#823

No description provided.

Rows
Columns