[PR #324] [MERGED] Implement ExtendedMetadata Method for Content Loading #324

Closed
opened 2026-02-27 08:12:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kokarare1212/librespot-python/pull/324
Author: @Googolplexed0
Created: 11/11/2025
Status: Merged
Merged: 11/13/2025
Merged by: @kokarare1212

Base: mainHead: proto-ext-metadata


📝 Commits (8)

  • 9481c1c have get_metadata_4_track() call new get_ext_metadata()
  • 778d8a2 Fix 400 errors
  • a403f3e Keep consistent dict type
  • f1dc977 Merge pull request #1 from sausa28/proto-ext-metadata
  • 5882f28 fix parsing, metadata now returns correctly
  • 3e52743 Better error handling for load_stream if None passed as track/episode or AudioFile
  • 10748b8 improved error catching on get_ext_metadata()
  • 8736aca add/mirror exception messages for PlayableContentFeeder loading content functions

📊 Changes

10 files changed (+506 additions, -105 deletions)

View changed files

📝 librespot/__init__.py (+1 -1)
📝 librespot/audio/__init__.py (+39 -40)
📝 librespot/core.py (+54 -63)
librespot/proto/EntityExtensionData_pb2.py (+35 -0)
librespot/proto/ExtendedMetadata_pb2.py (+44 -0)
librespot/proto/ExtensionKind_pb2.py (+26 -0)
proto/entity_extension_data.proto (+38 -0)
proto/extended_metadata.proto (+59 -0)
proto/extension_kind.proto (+209 -0)
📝 setup.py (+1 -1)

📄 Description

  • Fixes #321, #318
  • Add get_ext_metadata() as sub-function for existing get_metadata_4_XXXXXX function classes (extensible in future
  • Error handling for new metadata functions
  • Several improved error handlers for other audio functions
  • Reorganized LoadedStream for improved typehints (no functionality changed)
  • Version bump v0.0.10 (long overdue)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kokarare1212/librespot-python/pull/324 **Author:** [@Googolplexed0](https://github.com/Googolplexed0) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/13/2025 **Merged by:** [@kokarare1212](https://github.com/kokarare1212) **Base:** `main` ← **Head:** `proto-ext-metadata` --- ### 📝 Commits (8) - [`9481c1c`](https://github.com/kokarare1212/librespot-python/commit/9481c1c841c45fe07c4ad8d37ad76f950c25bbf5) have get_metadata_4_track() call new get_ext_metadata() - [`778d8a2`](https://github.com/kokarare1212/librespot-python/commit/778d8a2b5ab719b798ee7120a647f92e470514e8) Fix 400 errors - [`a403f3e`](https://github.com/kokarare1212/librespot-python/commit/a403f3eb9a01547141e33978e44adba7c587fe9a) Keep consistent dict type - [`f1dc977`](https://github.com/kokarare1212/librespot-python/commit/f1dc97778c6112841c4a37ed45179ca5a1417292) Merge pull request #1 from sausa28/proto-ext-metadata - [`5882f28`](https://github.com/kokarare1212/librespot-python/commit/5882f28213adaa113a07d68cf307a2ffd2464708) fix parsing, metadata now returns correctly - [`3e52743`](https://github.com/kokarare1212/librespot-python/commit/3e527435496f10e5615a96a0e06eda26664d7914) Better error handling for load_stream if None passed as track/episode or AudioFile - [`10748b8`](https://github.com/kokarare1212/librespot-python/commit/10748b8c5cac14d8afdf0faf72467f60c09d1eb2) improved error catching on get_ext_metadata() - [`8736aca`](https://github.com/kokarare1212/librespot-python/commit/8736aca27bfdf37a7882ea08cb3bfe91c69c78a0) add/mirror exception messages for PlayableContentFeeder loading content functions ### 📊 Changes **10 files changed** (+506 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `librespot/__init__.py` (+1 -1) 📝 `librespot/audio/__init__.py` (+39 -40) 📝 `librespot/core.py` (+54 -63) ➕ `librespot/proto/EntityExtensionData_pb2.py` (+35 -0) ➕ `librespot/proto/ExtendedMetadata_pb2.py` (+44 -0) ➕ `librespot/proto/ExtensionKind_pb2.py` (+26 -0) ➕ `proto/entity_extension_data.proto` (+38 -0) ➕ `proto/extended_metadata.proto` (+59 -0) ➕ `proto/extension_kind.proto` (+209 -0) 📝 `setup.py` (+1 -1) </details> ### 📄 Description - Fixes #321, #318 - Add get_ext_metadata() as sub-function for existing get_metadata_4_XXXXXX function classes (extensible in future - Error handling for new metadata functions - Several improved error handlers for other audio functions - Reorganized LoadedStream for improved typehints (no functionality changed) - Version bump v0.0.10 (long overdue) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 08:12:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot-python-kokarare1212#324
No description provided.