[PR #319] [MERGED] Change request.headers from Dicts to CaseInsensitiveDicts #321

Closed
opened 2026-02-27 08:12:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kokarare1212/librespot-python/pull/319
Author: @Googolplexed0
Created: 10/23/2025
Status: Merged
Merged: 10/23/2025
Merged by: @kokarare1212

Base: mainHead: no-case-headers


📝 Commits (1)

  • e007092 change all request.headers from dicts to CaseInsensitiveDicts

📊 Changes

8 files changed (+36 additions, -30 deletions)

View changed files

📝 examples/player/main.py (+2 -1)
📝 examples/server/main.py (+3 -2)
📝 librespot/audio/__init__.py (+6 -7)
📝 librespot/core.py (+16 -15)
📝 librespot/mercury.py (+3 -2)
📝 librespot/structure.py (+2 -1)
📝 librespot/zeroconf.py (+2 -1)
📝 librespot_player/__init__.py (+2 -1)

📄 Description

By default, this is the type that request.headers() returns. Prevents differences in capitalization from causing missing dict key errors. Tested for a month or two with no adverse side effects.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kokarare1212/librespot-python/pull/319 **Author:** [@Googolplexed0](https://github.com/Googolplexed0) **Created:** 10/23/2025 **Status:** ✅ Merged **Merged:** 10/23/2025 **Merged by:** [@kokarare1212](https://github.com/kokarare1212) **Base:** `main` ← **Head:** `no-case-headers` --- ### 📝 Commits (1) - [`e007092`](https://github.com/kokarare1212/librespot-python/commit/e0070925e2ecab77d7edf42269e14d0afd3592d4) change all request.headers from dicts to CaseInsensitiveDicts ### 📊 Changes **8 files changed** (+36 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `examples/player/main.py` (+2 -1) 📝 `examples/server/main.py` (+3 -2) 📝 `librespot/audio/__init__.py` (+6 -7) 📝 `librespot/core.py` (+16 -15) 📝 `librespot/mercury.py` (+3 -2) 📝 `librespot/structure.py` (+2 -1) 📝 `librespot/zeroconf.py` (+2 -1) 📝 `librespot_player/__init__.py` (+2 -1) </details> ### 📄 Description By default, this is the type that `request.headers()` returns. Prevents differences in capitalization from causing missing dict key errors. Tested for a month or two with no adverse side effects. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 08:12:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot-python-kokarare1212#321
No description provided.