mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #1309] Type error during sync #755
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#755
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Derkades on GitHub (Apr 23, 2021).
Original GitHub issue: https://github.com/koel/koel/issues/1309
To reproduce
This is the first time I am trying this software so it could be caused by an invalid file in my library.
Environment
@phanan commented on GitHub (Apr 26, 2021):
This looks like a getID3 issue to me, can you perhaps post it there?
For a workaround, it looks like the PHP installation is in strict mode, hence string-int coercion doesn't work.
@bubu8941 commented on GitHub (Apr 28, 2021):
Hello, I encounter the same problem in docker type installation.
@phanan : the bug you mentionned is here isn't it ?
So, do I have to pull another release of hyzual/koel docker image to make it work ?
And must we consider this Docker image as buggy ?
@phanan commented on GitHub (Apr 28, 2021):
The Docker image isn’t buggy, nor is strictly Koel in this regard. As you
linked it yourself, the bug appears to be in getID3 and unfortunately
there’s very little we can do about it. You might consider downgrading your
PHP version if that’s an option.
On Wed 28. Apr 2021 at 21:30 bubu8941 @.***> wrote:
@bubu8941 commented on GitHub (Apr 28, 2021):
Hmm, it's the PHP provided by the official Koel docker image as mentioned here.
So, must I consider to open a issue in Docker/koel project ?
@Derkades commented on GitHub (Apr 28, 2021):
It might be a good idea to have both php74 and php8 images if there are still php8 related bugs
Simply changing 8.0.3 to 7.4 in the dockerfile seems to work, maybe add a build arg to build for both versions?
@bubu8941 commented on GitHub (Apr 29, 2021):
@Derkades , thx, I confirm the workaround. Using php7.4 works.
@Hyzual commented on GitHub (May 1, 2021):
Hi, I've reverted php version to 7.4 in
hyzual/koel, could you please pull hyzual/koel:latest and let me know if it solved the scanning problems ?@bubu8941 commented on GitHub (May 4, 2021):
Hello,
I confirm it works , thx !!
PS : sorry for the delay.
Jonathan Régnier
Le sam. 1 mai 2021 à 13:50, Joris MASSON @.***> a
écrit :
@phanan commented on GitHub (May 7, 2021):
Glad it worked out!