[PR #651] [CLOSED] Fixes issue where FLAC would only partially play. #1309

New issue

Closed

opened 2026-02-26 03:30:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/651
Author: @ThisIsSet-L
Created: 9/18/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (3)

a47036d Fixes issue where FLAC would only partially play.
2ccc59e Fix whitespace
1db49ff Fix check "Avoid unused local variables such as '$bitRate'. "

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 app/Http/Streamers/TranscodingStreamer.php (+2 -3)

📄 Description

First time pull-requesting from a tag, so I hope I'm doing this right.

This seems to fix issue #600

Switching from variable bitrate to constant bitrate might not be a desirable option, but it stops the issues from happening. Maybe some more research into what is going on would be better, but this is a KwikFixx©

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/651 **Author:** [@ThisIsSet-L](https://github.com/ThisIsSet-L) **Created:** 9/18/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`a47036d`](https://github.com/koel/koel/commit/a47036d63117e3ba4165f1b3958665e5cc950337) Fixes issue where FLAC would only partially play. - [`2ccc59e`](https://github.com/koel/koel/commit/2ccc59e8a89d17037039fa0242431af0c1c0c19b) Fix whitespace - [`1db49ff`](https://github.com/koel/koel/commit/1db49ff54023d37f615b533c851bc7375ae50d2b) Fix check "Avoid unused local variables such as '$bitRate'. " ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Streamers/TranscodingStreamer.php` (+2 -3) </details> ### 📄 Description First time pull-requesting from a tag, so I hope I'm doing this right. This seems to fix issue #600 Switching from variable bitrate to constant bitrate might not be a desirable option, but it stops the issues from happening. Maybe some more research into what is going on would be better, but this is a KwikFixx© --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:32 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1309

No description provided.

Rows
Columns