mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #2] Files with non ASCII characters do not get saved correctly #1
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @juliusvdijk on GitHub (Dec 13, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/2
In my library there is a file "Major Lazer & DJ Snake - Lean On (feat. MØ) (Official Music Video).mp3" which is unplayable because the file path is stored as "Major Lazer & DJ Snake - Lean On (feat. M?) (Official Music Video).mp3".
I am able to store the Ø character in the song table which also fixes the playback issue.
This issue is happening with all non ASCII characters.
@phanan commented on GitHub (Dec 13, 2015):
Hmm. What DBMS are you using? I have quite a few Chinese songs in my MySQL and it works fine:
@phanan commented on GitHub (Dec 13, 2015):
And
@juliusvdijk commented on GitHub (Dec 13, 2015):
I am using MySQL on Windows using XAMPP.
In the console I am able to view the correct path so for some reason it just does not want to save in the right encoding. I tried to convert the encoding with mb_convert_encoding but that did not work.
However the title field gets saved succesfully...
Title: Major Lazer (Feat. MØ & DJ Snake) - Lean On (Claes Lanng Tropical Mix)
Path: .......\Major Lazer - Lean On (feat. M? & DJ Snake).mp3
@phanan commented on GitHub (Dec 13, 2015):
I don't have a Windows box here, so... can you
dd($file->getPathname())here and see if it's a PHP problem?@juliusvdijk commented on GitHub (Dec 13, 2015):
I've added this code:
I ran php artisan koel:sync --verbose and got this output.
In the database it is stored as:
@phanan commented on GitHub (Dec 13, 2015):
Just to double-check, what encoding is there for the field/table/db?
@juliusvdijk commented on GitHub (Dec 13, 2015):
The weirdest thing is that it saves the title from the ID3 tags correctly but not the path.
I overrode the updateOrCreate and the value of the path is still correct, I have no clue why that character gets converted to a ?.
@phanan commented on GitHub (Dec 14, 2015):
I don't know honestly. Once you enter
updateOrCreate(), it's the framework (Laravel) job. From what I know, there's no configuration that may affect this. Maybe open an issue here?@juliusvdijk commented on GitHub (Dec 14, 2015):
It seems to be an issue related to my PHP environment, I'll try running it in a virtual Linux environment to check if that fixes it.
@phanan commented on GitHub (Dec 14, 2015):
👍 I'll go ahead and close this issue then. Feel free to open a new one if the problem persists for you.