[PR #1841] [CLOSED] feat(playlist): store playlist order in localStorage #1902

New issue

Closed

opened 2026-02-26 03:32:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1841
Author: @ShetlandJ
Created: 10/7/2024
Status: ❌ Closed

Base: master ← Head: 1750-scroll-to-song

📝 Commits (6)

cce47e3 feat(playlist): store playlist order in localStorage
73758b1 fix(local storage): remove my version
4d9fd33 Revert test changes
c71187d fix(local storage): update localstorage key
02d2110 feat(local storage): revert test file change
bbdeb2d feat(local storage): revert index.ts changeas

📊 Changes

2 files changed (+49 additions, -11 deletions)

View changed files

📝 resources/assets/js/components/screens/PlaylistScreen.vue (+33 -8)
📝 resources/assets/js/components/song/SongList.vue (+16 -3)

📄 Description

Closes #1744

Hello 👋, I saw this open source app listed in a blog and wanted to try out contributing to it. This feature suggestion by @caendesilva seemed sensible.

I tried for a few days to get the vitest to work around the changes I've made to the function, but I just could not get the localStorage mocking to be correctly picked up. I would be happy to take pointers on adding a test that vitest will be satisfied by.

Relatively new to Typescript too, so I hope that this meets the standards.

Cheers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1841 **Author:** [@ShetlandJ](https://github.com/ShetlandJ) **Created:** 10/7/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1750-scroll-to-song` --- ### 📝 Commits (6) - [`cce47e3`](https://github.com/koel/koel/commit/cce47e3811cfb926c3b1e290ef06ed39302b7660) feat(playlist): store playlist order in localStorage - [`73758b1`](https://github.com/koel/koel/commit/73758b1c227ed44caf03e2cee014ec76704f9eb5) fix(local storage): remove my version - [`4d9fd33`](https://github.com/koel/koel/commit/4d9fd33ad96aa708d476b3fca238dd9589c275b4) Revert test changes - [`c71187d`](https://github.com/koel/koel/commit/c71187db0b74dd6c484cbc19adf2ddef873e2875) fix(local storage): update localstorage key - [`02d2110`](https://github.com/koel/koel/commit/02d2110fb72f2ec5ba5d9e43ee05630c98c16cf6) feat(local storage): revert test file change - [`bbdeb2d`](https://github.com/koel/koel/commit/bbdeb2da3b33a67052f4c08acd0b45c9aab2a919) feat(local storage): revert index.ts changeas ### 📊 Changes **2 files changed** (+49 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+33 -8) 📝 `resources/assets/js/components/song/SongList.vue` (+16 -3) </details> ### 📄 Description Closes #1744 Hello 👋, I saw this open source app listed in a [blog](https://www.amitmerchant.com/growing-list-of-well-built-open-source-apps-in-laravel/) and wanted to try out contributing to it. This feature suggestion by @caendesilva seemed sensible. I tried for a few days to get the vitest to work around the changes I've made to the function, but I just could not get the localStorage mocking to be correctly picked up. I would be happy to take pointers on adding a test that vitest will be satisfied by. Relatively new to Typescript too, so I hope that this meets the standards. Cheers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1902

No description provided.

Rows
Columns