[PR #1521] [MERGED] feat: cache routes and deprecate hashbang support #1744

New issue

Closed

opened 2026-02-26 03:32:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1521
Author: @phanan
Created: 10/9/2022
Status: ✅ Merged
Merged: 10/9/2022
Merged by: @phanan

Base: master ← Head: feat/cache-route

📝 Commits (1)

e0653ea feat: cache route and deprecate hashbang support

📊 Changes

18 files changed (+67 additions, -50 deletions)

View changed files

📝 resources/assets/js/components/album/AlbumCard.vue (+2 -2)
📝 resources/assets/js/components/artist/ArtistCard.vue (+1 -1)
📝 resources/assets/js/components/layout/app-footer/FooterExtraControls.vue (+1 -1)
📝 resources/assets/js/components/layout/app-footer/FooterMiddlePane.vue (+2 -2)
📝 resources/assets/js/components/layout/app-footer/__snapshots__/FooterExtraControls.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/layout/app-footer/__snapshots__/FooterMiddlePane.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/layout/main-wrapper/Sidebar.vue (+9 -9)
📝 resources/assets/js/components/playlist/PlaylistSidebarItem.vue (+3 -3)
📝 resources/assets/js/components/screens/AlbumScreen.vue (+1 -1)
📝 resources/assets/js/components/song/SongCard.vue (+1 -1)
📝 resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/ui/__snapshots__/BtnScrollToTop.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/user/UserBadge.vue (+1 -1)
📝 resources/assets/js/components/user/__snapshots__/UserBadge.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/utils/GlobalEventListeners.vue (+1 -3)
📝 resources/assets/js/router.ts (+38 -19)
📝 resources/assets/js/stores/songStore.spec.ts (+1 -1)
📝 resources/assets/js/stores/songStore.ts (+1 -1)

📄 Description

Route matching is now cached.
Hashbang has been long deprecated by Google. Might as well remove its support from Koel (not that it's any important anyway). For now, backward compatibility is maintained.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1521 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/9/2022 **Status:** ✅ Merged **Merged:** 10/9/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/cache-route` --- ### 📝 Commits (1) - [`e0653ea`](https://github.com/koel/koel/commit/e0653ea37b9b51199a448093b48b075504f97813) feat: cache route and deprecate hashbang support ### 📊 Changes **18 files changed** (+67 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/album/AlbumCard.vue` (+2 -2) 📝 `resources/assets/js/components/artist/ArtistCard.vue` (+1 -1) 📝 `resources/assets/js/components/layout/app-footer/FooterExtraControls.vue` (+1 -1) 📝 `resources/assets/js/components/layout/app-footer/FooterMiddlePane.vue` (+2 -2) 📝 `resources/assets/js/components/layout/app-footer/__snapshots__/FooterExtraControls.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/layout/app-footer/__snapshots__/FooterMiddlePane.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/layout/main-wrapper/Sidebar.vue` (+9 -9) 📝 `resources/assets/js/components/playlist/PlaylistSidebarItem.vue` (+3 -3) 📝 `resources/assets/js/components/screens/AlbumScreen.vue` (+1 -1) 📝 `resources/assets/js/components/song/SongCard.vue` (+1 -1) 📝 `resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/ui/__snapshots__/BtnScrollToTop.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/user/UserBadge.vue` (+1 -1) 📝 `resources/assets/js/components/user/__snapshots__/UserBadge.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/utils/GlobalEventListeners.vue` (+1 -3) 📝 `resources/assets/js/router.ts` (+38 -19) 📝 `resources/assets/js/stores/songStore.spec.ts` (+1 -1) 📝 `resources/assets/js/stores/songStore.ts` (+1 -1) </details> ### 📄 Description - Route matching is now cached. - Hashbang has been long deprecated by Google. Might as well remove its support from Koel (not that it's any important anyway). For now, backward compatibility is maintained. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:43 +03:00

[PR #1841] [CLOSED] feat(playlist): store playlist order in localStorage #1902

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1744

No description provided.

Rows
Columns