[PR #1672] [CLOSED] Themed scrollbars #1841

New issue

Closed

opened 2026-02-26 03:32:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1672
Author: @SketchNI
Created: 4/28/2023
Status: ❌ Closed

Base: master ← Head: themed-scrollbars

📝 Commits (4)

3bbc4f6 Use dark color scheme when device is set to prefer dark mode except on inputs
b32c3dc Remove css forcing inputs to be always light mode and brighten the placeholder in dark mode.
6b080cc Nix the prefers-color-scheme media query and force dark mode for everything
434e76a Scrollbars are styled closer to the current themes colors.

📊 Changes

3 files changed (+191 additions, -117 deletions)

View changed files

📝 resources/assets/js/themes.ts (+156 -116)
📝 resources/assets/js/types.d.ts (+2 -0)
📝 resources/assets/sass/partials/_shared.scss (+33 -1)

📄 Description

Scrollbars are styled closer to the current themes colors. Due to limitations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now.

I think either eslint (or phpstorms built-in eslint rules) completely munched the single-quotes into double-quotes which is why this PR is larger than I intended. I can reverse this if you want.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1672 **Author:** [@SketchNI](https://github.com/SketchNI) **Created:** 4/28/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `themed-scrollbars` --- ### 📝 Commits (4) - [`3bbc4f6`](https://github.com/koel/koel/commit/3bbc4f6db938fd44f973453392ed1bd1ffef4c3c) Use dark color scheme when device is set to prefer dark mode except on inputs - [`b32c3dc`](https://github.com/koel/koel/commit/b32c3dc8e981a73280de81d1e1ce2d5b7d9e3fe8) Remove css forcing inputs to be always light mode and brighten the placeholder in dark mode. - [`6b080cc`](https://github.com/koel/koel/commit/6b080cce9d16194de38d9b77a16b064785a2c60f) Nix the `prefers-color-scheme` media query and force dark mode for everything - [`434e76a`](https://github.com/koel/koel/commit/434e76aff54c2951ca7a40941fdd2d7671ae352c) Scrollbars are styled closer to the current themes colors. ### 📊 Changes **3 files changed** (+191 additions, -117 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/themes.ts` (+156 -116) 📝 `resources/assets/js/types.d.ts` (+2 -0) 📝 `resources/assets/sass/partials/_shared.scss` (+33 -1) </details> ### 📄 Description Scrollbars are styled closer to the current themes colors. Due to limitations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now. I think either eslint (or phpstorms built-in eslint rules) completely munched the single-quotes into double-quotes which is why this PR is larger than I intended. I can reverse this if you want. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:30 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:43 +03:00

[PR #1841] [CLOSED] feat(playlist): store playlist order in localStorage #1902

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1841

No description provided.

Rows
Columns