[PR #1457] fix(web): Context menu and highlight changes #1830

New issue

Open

opened 2026-03-02 11:59:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1457
Author: @haappi
Created: 5/24/2025
Status: 🔄 Open

Base: main ← Head: fix-highlight-issues

📝 Commits (10+)

ce8bb25 fix(web): Context menu and highlight changes
dc0b3bb feat(web): Add copy to clipboard, minor UI changes
945cbc9 Shoddy impl of scrolling FAB
ad0aab1 Make highlights... highlight even more when clicked from sidedbar
775487a fix(web): add comment and change copy to clipboard render behavior
6011eac fix(web): Didn't realize tailwind required colors to be defined in a file...
360e2c7 hahahahah im better in everrway
e9cebe9 allow nmew lines to work
2fe6657 fix highlight darker shade thing not working over new lines
d2ca84f this took a lot of ai (additional fix for new lines)

📊 Changes

7 files changed (+853 additions, -298 deletions)

View changed files

📝 apps/web/components/dashboard/highlights/HighlightCard.tsx (+80 -7)
📝 apps/web/components/dashboard/preview/BookmarkHtmlHighlighter.tsx (+425 -280)
➕ apps/web/components/dashboard/preview/ColorPickerMenu.tsx (+127 -0)
📝 apps/web/components/dashboard/preview/HighlightsBox.tsx (+8 -6)
➕ apps/web/components/dashboard/preview/highlightUtils.ts (+202 -0)
📝 apps/web/components/dashboard/preview/highlights.ts (+10 -4)
📝 apps/web/components/ui/copy-button.tsx (+1 -1)

📄 Description

fix(web): Fixes #997.

Additionally, slightly improves performance applying Highlights.
#1348 attempted to show the highlight menu on mobile devices, but it wasn't working for me on 14 pro, Safari. This PR also addresses that.

todo

Make the FAB scroll with the relative position where it was invoked
Make it a little more obvious as to which highlight has a FAB open (deeper shade? Excel like “cut” animations, small indented arrow?)
Copy button on FAB
Make task 1 work on mobile
Make task 2 work on mobile
Allow newlines to render properly on the side view (#1485)
Simplify AI generated slops

(edit) removed a few tasks as they're irrelevant to the scope of the pr

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1457 **Author:** [@haappi](https://github.com/haappi) **Created:** 5/24/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-highlight-issues` --- ### 📝 Commits (10+) - [`ce8bb25`](https://github.com/karakeep-app/karakeep/commit/ce8bb259a8720ae7be38820d314f440b598d73c5) fix(web): Context menu and highlight changes - [`dc0b3bb`](https://github.com/karakeep-app/karakeep/commit/dc0b3bb901c635bcb6661c6e859c3d40a3e7ac6c) feat(web): Add copy to clipboard, minor UI changes - [`945cbc9`](https://github.com/karakeep-app/karakeep/commit/945cbc9bc70daf296e3fbd223848d86a09c848d6) Shoddy impl of scrolling FAB - [`ad0aab1`](https://github.com/karakeep-app/karakeep/commit/ad0aab1c243a2f57f6dcfaf2f277075a40078243) Make highlights... highlight even more when clicked from sidedbar - [`775487a`](https://github.com/karakeep-app/karakeep/commit/775487a488b5cdbcc088a272152a07798e709c55) fix(web): add comment and change copy to clipboard render behavior - [`6011eac`](https://github.com/karakeep-app/karakeep/commit/6011eacb9bb6264878d424af1c3afc85c2db5914) fix(web): Didn't realize tailwind required colors to be defined in a file... - [`360e2c7`](https://github.com/karakeep-app/karakeep/commit/360e2c7f4c08ba43698e52c9d3b4f4b2b45043ed) hahahahah im better in everrway - [`e9cebe9`](https://github.com/karakeep-app/karakeep/commit/e9cebe900c32dd87b0a91d8f6d9a30c36d0eb86e) allow nmew lines to work - [`2fe6657`](https://github.com/karakeep-app/karakeep/commit/2fe66576f1f84e946949b85080e09dc614dc8295) fix highlight darker shade thing not working over new lines - [`d2ca84f`](https://github.com/karakeep-app/karakeep/commit/d2ca84fa58fc2859b7e6dfc360f20463a9906e55) this took a lot of ai (additional fix for new lines) ### 📊 Changes **7 files changed** (+853 additions, -298 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/highlights/HighlightCard.tsx` (+80 -7) 📝 `apps/web/components/dashboard/preview/BookmarkHtmlHighlighter.tsx` (+425 -280) ➕ `apps/web/components/dashboard/preview/ColorPickerMenu.tsx` (+127 -0) 📝 `apps/web/components/dashboard/preview/HighlightsBox.tsx` (+8 -6) ➕ `apps/web/components/dashboard/preview/highlightUtils.ts` (+202 -0) 📝 `apps/web/components/dashboard/preview/highlights.ts` (+10 -4) 📝 `apps/web/components/ui/copy-button.tsx` (+1 -1) </details> ### 📄 Description fix(web): Fixes #997. Additionally, slightly improves performance applying Highlights. #1348 attempted to show the highlight menu on mobile devices, but it wasn't working for me on 14 pro, Safari. This PR also addresses that. ## todo - [x] Make the FAB scroll with the relative position where it was invoked - [x] Make it a little more obvious as to which highlight has a FAB open (deeper shade? Excel like “cut” animations, small indented arrow?) - [x] Copy button on FAB - [x] Make task 1 work on mobile - [x] Make task 2 work on mobile - [x] Allow newlines to render properly on the side view (#1485) - [x] Simplify AI generated slops (edit) removed a few tasks as they're irrelevant to the scope of the pr --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-02 11:59:23 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1830

No description provided.

Rows
Columns