starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-25 16:55:59 +03:00

[GH-ISSUE #122] Handling request failures when build number is obtained from GitHub #51

New issue

Closed

opened 2026-03-16 12:59:34 +03:00 by kerem · 8 comments

kerem commented

2026-03-16 12:59:34 +03:00

Owner

Originally created by @NBTX on GitHub (Aug 31, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/122

Originally assigned to: @NBTX on GitHub.

Per discussion in #121, this issue is to determine what we should do if we can't get the latest build number from GitHub at build time. The options I can think of are as follows:

Hide the name section in the version information.
Use 'deep clone' on Travis and get the tag from the git history. (Could make builds slower over time but probably wouldn't have that big an impact)
Get it from package.json but make sure the value in package.json stays up-to-date. (Perhaps use GitHub Actions or something to automatically change it to the version number in GitHub releases?) - Overall this is my preferred option.

/CC: @larouxn @liyasthomas

Originally created by @NBTX on GitHub (Aug 31, 2019). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/122 Originally assigned to: @NBTX on GitHub. Per discussion in #121, this issue is to determine what we should do if we can't get the latest build number from GitHub at build time. The options I can think of are as follows: 1. Hide the name section in the version information. 2. Use 'deep clone' on Travis and get the tag from the git history. (Could make builds slower over time but probably wouldn't have that big an impact) 3. Get it from `package.json` but make sure the value in `package.json` stays up-to-date. (Perhaps use GitHub Actions or something to automatically change it to the version number in GitHub releases?) - Overall this is my preferred option. /CC: @larouxn @liyasthomas

kerem

2026-03-16 12:59:34 +03:00

closed this issue
added the
good first issue

discussion
labels

kerem commented

2026-03-16 12:59:51 +03:00

Author

Owner

@liyasthomas commented on GitHub (Aug 31, 2019):

I vote for updating version number from package.json
This seems the correct way to handle this, it also helps in tags as well.

Lets hear from @larouxn as well

@liyasthomas commented on GitHub (Aug 31, 2019): I vote for updating version number from package.json This seems the correct way to handle this, it also helps in tags as well. Lets hear from @larouxn as well

kerem commented

2026-03-16 12:59:56 +03:00

Author

Owner

@NBTX commented on GitHub (Aug 31, 2019):

Actually funny thing, I decided 2 was my favorite option but then I came up with 3 because I wanted to put 3 things instead of 2 lol.
So thinking about it, I also prefer 3.

@NBTX commented on GitHub (Aug 31, 2019): Actually funny thing, I decided 2 was my favorite option but then I came up with 3 because I wanted to put 3 things instead of 2 lol. So thinking about it, I also prefer 3.

kerem commented

2026-03-16 13:00:01 +03:00

Author

Owner

@larouxn commented on GitHub (Aug 31, 2019):

We should keep package.json version up to date anyway. So, if a solution for build numbers also ensures that, then that's a double win. 🙌

@larouxn commented on GitHub (Aug 31, 2019): We _should_ keep package.json version up to date anyway. So, if a solution for build numbers _also_ ensures that, then that's a double win. 🙌

kerem commented

2026-03-16 13:00:06 +03:00

Author

Owner

@NBTX commented on GitHub (Aug 31, 2019):

Exactly! ^
Guess I'll get working on 3 then haha

@NBTX commented on GitHub (Aug 31, 2019): Exactly! ^ Guess I'll get working on 3 then haha

kerem commented

2026-03-16 13:00:11 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 15, 2019):

@NBTX this issue seems to be absolute. Would you mind closing it?

@liyasthomas commented on GitHub (Sep 15, 2019): @NBTX this issue seems to be absolute. Would you mind closing it?

kerem commented

2026-03-16 13:00:16 +03:00

Author

Owner

@NBTX commented on GitHub (Sep 29, 2019):

@liyasthomas absolute?

@NBTX commented on GitHub (Sep 29, 2019): @liyasthomas absolute?

kerem commented

2026-03-16 13:00:21 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 29, 2019):

Sorry. Oftentimes, version number is still fetched from package.json causing version tag without "v" before the tag. This issue is persisting.

@liyasthomas commented on GitHub (Sep 29, 2019): Sorry. Oftentimes, version number is still fetched from `package.json` causing version tag without "v" before the tag. This issue is persisting.

kerem commented

2026-03-16 13:00:26 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 5, 2019):

Now the version number is correctly fetching from package.json and release tag, so I think I should this issue.

@liyasthomas commented on GitHub (Nov 5, 2019): Now the version number is correctly fetching from package.json and release tag, so I think I should this issue.

kerem referenced this issue

2026-03-17 00:05:47 +03:00

[PR #51] [MERGED] Migrate nuxt #2389