[PR #3898] [MERGED] hotfix: reset infra-config bug #4580

Closed
opened 2026-03-17 02:06:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3898
Author: @balub
Created: 3/14/2024
Status: Merged
Merged: 3/14/2024
Merged by: @AndrewBastin

Base: release/2024.3.0Head: hotfix/infra-config-reset-bug


📝 Commits (3)

  • e302ee9 fix: changed value of IS_FIRST_TIME_INFRA_SETUP infra-config in reset method
  • 8776572 chore: added a list of infra-configs to excludef from reset
  • 64dca70 chore: changed hoppscotch-old-backend target to prod

📊 Changes

2 files changed (+17 additions, -14 deletions)

View changed files

📝 docker-compose.yml (+2 -2)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+15 -12)

📄 Description

Closes HSB-375

Description

This in PR we add a fix to an bug identified in the method responsible for resetting the infra-configs and we also exclude some infra-configs from getting reset too.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3898 **Author:** [@balub](https://github.com/balub) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `hotfix/infra-config-reset-bug` --- ### 📝 Commits (3) - [`e302ee9`](https://github.com/hoppscotch/hoppscotch/commit/e302ee93da14bc252a39601f993c7c4399bd0d89) fix: changed value of IS_FIRST_TIME_INFRA_SETUP infra-config in reset method - [`8776572`](https://github.com/hoppscotch/hoppscotch/commit/8776572c1b769faef98d3b2a3693f16ed40f9409) chore: added a list of infra-configs to excludef from reset - [`64dca70`](https://github.com/hoppscotch/hoppscotch/commit/64dca702132ce00a775e2ba8944d5a32b79871d7) chore: changed hoppscotch-old-backend target to prod ### 📊 Changes **2 files changed** (+17 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose.yml` (+2 -2) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+15 -12) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes HSB-375 ### Description <!-- Add a brief description of the pull request --> This in PR we add a fix to an bug identified in the method responsible for resetting the infra-configs and we also exclude some infra-configs from getting reset too. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behaviour, etc. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:06:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4580
No description provided.