mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4583] [MERGED] chore(cli): drop Node.js v18 support #4864
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4864
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4583
Author: @jamesgeorge007
Created: 12/2/2024
Status: ✅ Merged
Merged: 12/2/2024
Merged by: @jamesgeorge007
Base:
main← Head:cli-drop-node-v18-support📝 Commits (1)
5c5343echore: drop Node.js v18 support for the CLI📊 Changes
4 files changed (+129 additions, -74 deletions)
View changed files
📝
packages/hoppscotch-cli/bin/hopp.js(+39 -9)📝
packages/hoppscotch-cli/package.json(+7 -6)📝
packages/hoppscotch-cli/tsup.config.ts(+2 -2)📝
pnpm-lock.yaml(+81 -57)📄 Description
What's changed
This PR aims to drop Node.js
v18support for the CLI. Also, the user is warned if they are on an unsupported Node.js version.Context: There were compatibility issues observed from
v0.12.0of the CLI with Node.js v18 and withv0.13.0introduced theFileAPI as part of the public data structured maintained underhoppscotch-datawhich gets inlined in the CLI bundle leading to errors while installing.Ref: #4578, #4580, HFE-680.
Changes
semveras a dev dependency for seamless version checks that are inlined in the CLI bundle.nodeversion under theenginesfield as part ofpackage.json.Preview
Notes to reviewers
Please pull the CLI published on the Verdaccio instance and verify the error reporting flows on unsupported Node.js versions and other flows in general.
Also, for Node.js versions before
14, there might be errors with the usage of top-levelawait, optional chaining, etc, which can be ignored since they have reached EOL.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
README#4969