[PR #2560] [MERGED] Hightlight environment variable with a dash '-' in its name #3898

Closed
opened 2026-03-17 01:28:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2560
Author: @anwarulislam
Created: 8/6/2022
Status: Merged
Merged: 8/8/2022
Merged by: @liyasthomas

Base: mainHead: fix/highlight-env-dash


📝 Commits (1)

  • 6121172 fix: highlight env variables with dash

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-app/helpers/editor/extensions/HoppEnvironment.ts (+4 -3)

📄 Description

Closes #2554

Description

The issue is when having an environment variable with a dash '-' in its name, the variable is not colorized in the URL. It's fixed by this PR.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2560 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 8/6/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `fix/highlight-env-dash` --- ### 📝 Commits (1) - [`6121172`](https://github.com/hoppscotch/hoppscotch/commit/61211728574b8e95ee777340fbc97680441123fd) fix: highlight env variables with dash ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/helpers/editor/extensions/HoppEnvironment.ts` (+4 -3) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #2554 <!-- Issue # here --> ### Description The issue is when having an environment variable with a dash '-' in its name, the variable is not colorized in the URL. It's fixed by this PR. <!-- Add a brief description of the pull request --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behavior, etc. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:28:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3898
No description provided.