[PR #3502] [MERGED] fix(common): prevented truncating parameters #4413

New issue

Closed

opened 2026-03-17 01:57:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:57:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3502
Author: @ajmalmohad
Created: 11/7/2023
Status: ✅ Merged
Merged: 12/3/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: bug/truncated-params

📝 Commits (2)

c50afa3 fix(common): prevented truncating parameters
a941f85 fix: removed redundant check

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/new-codegen/har.ts (+9 -1)

📄 Description

Closes #3461

Description

Originally, the parameter key-value pairs were being split using all colons, which caused issues when the value field contained colons as well. To address this, I developed a function that separates the key and value by the first occurrence of a colon.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3502 **Author:** [@ajmalmohad](https://github.com/ajmalmohad) **Created:** 11/7/2023 **Status:** ✅ Merged **Merged:** 12/3/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `bug/truncated-params` --- ### 📝 Commits (2) - [`c50afa3`](https://github.com/hoppscotch/hoppscotch/commit/c50afa3fad86b1f2b3c5f0c4a749b9b9ead21fe5) fix(common): prevented truncating parameters - [`a941f85`](https://github.com/hoppscotch/hoppscotch/commit/a941f857f21171621b3df1775f3532382901f808) fix: removed redundant check ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/new-codegen/har.ts` (+9 -1) </details> ### 📄 Description   Closes #3461 ### Description Originally, the parameter key-value pairs were being split using all colons, which caused issues when the value field contained colons as well. To address this, I developed a function that separates the key and value by the first occurrence of a colon.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information ![Screenshot from 2023-11-07 12-53-25](https://github.com/hoppscotch/hoppscotch/assets/55492635/b599dca1-1b0e-4d40-b0bf-0414b33c67c9) ![Screenshot from 2023-11-07 12-53-02](https://github.com/hoppscotch/hoppscotch/assets/55492635/e41d577d-de68-4dfa-b5e5-0e340222bf39) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>