mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4413] Add lighter shade in dark mode #4790
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4790
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4413
Author: @gitadityakumar
Created: 10/8/2024
Status: 🔄 Open
Base:
main← Head:feature-drakmode-color📝 Commits (1)
66f1845add lighter shade in dark mode📊 Changes
1 file changed (+36 additions, -35 deletions)
View changed files
📝
packages/hoppscotch-common/assets/themes/base-themes.scss(+36 -35)📄 Description
Closes #4390
What's changed
Dark mode
Black mode
Notes to reviewers
Although #4390 mentioned allowing the user to tweak the theme in more detail, or at least choose a specific background color, I think updating the color of dark mode is enough. However, if you still need an element or slider that can change the color of the selected mode, I can implement that. It would also be great to add a "Custom Mode" button, which would include a slider allowing users to change their background color according to their needs.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.