[PR #4413] Add lighter shade in dark mode #4790

Open
opened 2026-03-17 02:17:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4413
Author: @gitadityakumar
Created: 10/8/2024
Status: 🔄 Open

Base: mainHead: feature-drakmode-color


📝 Commits (1)

  • 66f1845 add lighter shade in dark mode

📊 Changes

1 file changed (+36 additions, -35 deletions)

View changed files

📝 packages/hoppscotch-common/assets/themes/base-themes.scss (+36 -35)

📄 Description

Closes #4390

What's changed

  • Updated the color of dark mode to help users distinguish between dark and black modes.
  • Here’s how it looks now:

Dark mode

dark mode

Black mode

black mode

Notes to reviewers

Although #4390 mentioned allowing the user to tweak the theme in more detail, or at least choose a specific background color, I think updating the color of dark mode is enough. However, if you still need an element or slider that can change the color of the selected mode, I can implement that. It would also be great to add a "Custom Mode" button, which would include a slider allowing users to change their background color according to their needs.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4413 **Author:** [@gitadityakumar](https://github.com/gitadityakumar) **Created:** 10/8/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature-drakmode-color` --- ### 📝 Commits (1) - [`66f1845`](https://github.com/hoppscotch/hoppscotch/commit/66f18452beb201fa382867e3f2d74932bb99faed) add lighter shade in dark mode ### 📊 Changes **1 file changed** (+36 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/assets/themes/base-themes.scss` (+36 -35) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple PRs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #4390 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed - Updated the color of dark mode to help users distinguish between dark and black modes. - Here’s how it looks now: #### Dark mode <img width="1032" alt="dark mode" src="https://github.com/user-attachments/assets/892e116f-cfd6-452d-9f5e-c3061d01aed5"> #### Black mode <img width="959" alt="black mode" src="https://github.com/user-attachments/assets/a461389a-1d7e-440e-9c33-2b1e39897abf"> ### Notes to reviewers Although #4390 mentioned allowing the user to tweak the theme in more detail, or at least choose a specific background color, I think updating the color of dark mode is enough. However, if you still need an element or slider that can change the color of the selected mode, I can implement that. It would also be great to add a "Custom Mode" button, which would include a slider allowing users to change their background color according to their needs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4790
No description provided.