[PR #1721] [MERGED] fix: modal backdrop click #3461

New issue

Closed

opened 2026-03-17 01:04:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:04:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1721
Author: @s-r-x
Created: 6/15/2021
Status: ✅ Merged
Merged: 6/15/2021
Merged by: @liyasthomas

Base: main ← Head: fix/modal-overlay-mouseup

📝 Commits (1)

c3411ba fix: do not close modal if mousedown event was on the content but mouseup on the backdrop

📊 Changes

1 file changed (+22 additions, -3 deletions)

View changed files

📝 components/smart/Modal.vue (+22 -3)

📄 Description

Before:
https://user-images.githubusercontent.com/41614937/122031270-fc5c9f00-cde7-11eb-941b-d62c28ad691a.mp4

After:
https://user-images.githubusercontent.com/41614937/122031335-0a122480-cde8-11eb-86a2-4819e97c34d0.mp4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1721 **Author:** [@s-r-x](https://github.com/s-r-x) **Created:** 6/15/2021 **Status:** ✅ Merged **Merged:** 6/15/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `fix/modal-overlay-mouseup` --- ### 📝 Commits (1) - [`c3411ba`](https://github.com/hoppscotch/hoppscotch/commit/c3411ba0cf32f21ce31e9b9489f825a2ba13fdff) fix: do not close modal if mousedown event was on the content but mouseup on the backdrop ### 📊 Changes **1 file changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `components/smart/Modal.vue` (+22 -3) </details> ### 📄 Description Before: https://user-images.githubusercontent.com/41614937/122031270-fc5c9f00-cde7-11eb-941b-d62c28ad691a.mp4 After: https://user-images.githubusercontent.com/41614937/122031335-0a122480-cde8-11eb-86a2-4819e97c34d0.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>