mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #985] Is published version stale? (release of master needed) #584
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#584
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chunyingw on GitHub (Jan 8, 2020).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/985
Describe the bug
I am downloading trust-dns-resolver crate from crates.io which was published 4 days ago. However the loaded crate seem stable, does not contain the PR#979 (merged 6 days ago) nor PR#975 (merged 11 days ago). Is this expected?
Version:
Crate: trust-dns-resolver
Version: 0.18.1
@bluejekyll commented on GitHub (Jan 8, 2020):
Yes, that was a patch for a specific bug. It was released out of
releases/0.18specifically targetting a server issue. Do you need me to release those changes? I need to see if we need to bump to 0.19 or not...@chunyingw commented on GitHub (Jan 8, 2020):
Yes, please. I am working on porting it into Fuchsia officially.
On Wed, Jan 8, 2020, 5:39 PM Benjamin Fry notifications@github.com wrote:
@chunyingw commented on GitHub (Jan 9, 2020):
I meant
staleinstead ofstablein the title :)@bluejekyll commented on GitHub (Jan 11, 2020):
@chunyingw I'm reviewing interfaces, it looks like we have some naming that I want to try and clean up.
@chunyingw commented on GitHub (Jan 11, 2020):
Sure, thanks for cleaning up. I tried the the new version on Fuchsia, it works well.
@bluejekyll commented on GitHub (Jan 11, 2020):
FYI. On that PR, I want to drop the usage of
failureand convert tothiserror, if it’s not a ton of work. Do you have any issue with that?@bluejekyll commented on GitHub (Jan 11, 2020):
Now’s a good time to do that since I have to bump to 0.19 anyway.
@chunyingw commented on GitHub (Jan 11, 2020):
It is great. No issue for me. We dropped failure on Fuchsia a couple of
weeks ago.
On Sat, Jan 11, 2020, 12:04 PM Benjamin Fry notifications@github.com
wrote:
@bluejekyll commented on GitHub (Jan 14, 2020):
Got delayed on this over the weekend and yesterday. I'll be pushing a new release later today.
@chunyingw commented on GitHub (Jan 14, 2020):
Cool, thx.
@bluejekyll commented on GitHub (Jan 15, 2020):
0.19.0 was published: https://crates.io/crates/trust-dns-resolver/0.19.0
@chunyingw commented on GitHub (Jan 15, 2020):
Thanks. I tried it out on Fuchsia. trust-dns-proto is good to go.
However because the way trust-dns-resolver Cargo.toml file is written, by default the tokio-runtime feature of trust-dns-proto is enabled, so it is pulling down tokio crates as well, which is not good. I need to solve this issue before I can port trust-dns-resolver to Fuchsia.
@bluejekyll commented on GitHub (Jan 16, 2020):
Ok. I think changeling the dependency from resolver to proto to pull proto with no default features would fix that, right?
@chunyingw commented on GitHub (Jan 16, 2020):
Yes that is what I am thinking as well. I will work on that tomorrow.
On Wed, Jan 15, 2020, 7:37 PM Benjamin Fry notifications@github.com wrote: