[PR #584] [MERGED] strictly enforce name and label lengths during label parsing #1535

New issue

Closed

opened 2026-03-16 02:11:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:11:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/584
Author: @bluejekyll
Created: 10/12/2018
Status: ✅ Merged
Merged: 10/12/2018
Merged by: @bluejekyll

Base: master ← Head: stricter-name-validation

📝 Commits (1)

36ae064 strictly enforce name and label lengths during label parsing

📊 Changes

5 files changed (+183 additions, -86 deletions)

View changed files

📝 proto/benches/name_benches.rs (+3 -3)
📝 proto/src/error.rs (+19 -4)
📝 proto/src/rr/domain/name.rs (+139 -75)
📝 proto/src/serialize/binary/decoder.rs (+18 -3)
📝 proto/src/serialize/binary/encoder.rs (+4 -1)

📄 Description

fyi @andrewtj

Took your advice. After further investigation, there were two gaps. I used your test verbatim, I hope that's alright with you.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/584 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/12/2018 **Status:** ✅ Merged **Merged:** 10/12/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `stricter-name-validation` --- ### 📝 Commits (1) - [`36ae064`](https://github.com/hickory-dns/hickory-dns/commit/36ae064229288bee4aa4c7f067edfd31f9be6a0b) strictly enforce name and label lengths during label parsing ### 📊 Changes **5 files changed** (+183 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `proto/benches/name_benches.rs` (+3 -3) 📝 `proto/src/error.rs` (+19 -4) 📝 `proto/src/rr/domain/name.rs` (+139 -75) 📝 `proto/src/serialize/binary/decoder.rs` (+18 -3) 📝 `proto/src/serialize/binary/encoder.rs` (+4 -1) </details> ### 📄 Description fyi @andrewtj Took your advice. After further investigation, there were two gaps. I used your test verbatim, I hope that's alright with you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>