[GH-ISSUE #2422] `hickory-server` `+dnssec-ring` does not build with Rust 1.79 #985

New issue

Closed

opened 2026-03-16 01:10:13 +03:00 by kerem · 4 comments

kerem commented

2026-03-16 01:10:13 +03:00

Owner

Originally created by @japaric on GitHub (Sep 5, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2422

Describe the bug
What the title says. As I understand, the current MSRV is 1.70 as per CI.

To Reproduce
Steps to reproduce the behavior:

$ cargo +1.79.0 build -p hickory-server --features dnssec-ring
(..)
error[E0277]: the trait bound `[u8]: Default` is not satisfied
   --> crates/server/src/config/dnssec.rs:262:9
    |
262 |         /// The salt used for hashing.
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Default` is not implemented for `[u8]`, which is required by `Arc<[u8]>: Default`
    |
    = help: the following other types implement trait `Default`:
              &[T]
              &mut [T]
              [T; 0]
              [T; 10]
              [T; 11]
              [T; 12]
              [T; 13]
              [T; 14]
            and 27 others
    = note: required for `Arc<[u8]>` to implement `Default`

Expected behavior
The code should compile with that toolchain version.

System:

OS: Ubuntu
Architecture: x86_64
Version 22.04
rustc version: 1.79.0

Version:
Crate: hickory-server
Version: 9ad0cf2590

Originally created by @japaric on GitHub (Sep 5, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2422 **Describe the bug** What the title says. As I understand, the current MSRV is 1.70 as [per CI](https://github.com/hickory-dns/hickory-dns/blob/9ad0cf2590ee6fd5a2ac0237fa417b9b30555bea/.github/workflows/test.yml#L127). **To Reproduce** Steps to reproduce the behavior: ``` console $ cargo +1.79.0 build -p hickory-server --features dnssec-ring (..) error[E0277]: the trait bound `[u8]: Default` is not satisfied --> crates/server/src/config/dnssec.rs:262:9 | 262 | /// The salt used for hashing. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Default` is not implemented for `[u8]`, which is required by `Arc<[u8]>: Default` | = help: the following other types implement trait `Default`: &[T] &mut [T] [T; 0] [T; 10] [T; 11] [T; 12] [T; 13] [T; 14] and 27 others = note: required for `Arc<[u8]>` to implement `Default` ``` **Expected behavior** The code should compile with that toolchain version. **System:** - OS: Ubuntu - Architecture: x86_64 - Version 22.04 - rustc version: 1.79.0 **Version:** Crate: `hickory-server` Version: 9ad0cf2590ee6fd5a2ac0237fa417b9b30555bea

kerem

2026-03-16 01:10:13 +03:00

closed this issue
added the
ops

cleanup
labels

kerem commented

2026-03-16 01:10:29 +03:00

Author

Owner

@japaric commented on GitHub (Sep 5, 2024):

the past-future job should probably run a check with all Cargo features enabled to avoid this in the future

@japaric commented on GitHub (Sep 5, 2024): the `past-future` job should probably run a check with all Cargo features enabled to avoid this in the future

kerem commented

2026-03-16 01:10:34 +03:00

Author

Owner

@djc commented on GitHub (Sep 25, 2024):

I think it is still reasonable to exclude some dependencies from our MSRV jobs, although I agree that it might be better to include some/most of them. I made a proposal to handle this differently in https://github.com/hickory-dns/hickory-dns/pull/2028, but IIRC @bluejekyll wasn't a fan.

@djc commented on GitHub (Sep 25, 2024): I think it is still reasonable to exclude some dependencies from our MSRV jobs, although I agree that it might be better to include some/most of them. I made a proposal to handle this differently in https://github.com/hickory-dns/hickory-dns/pull/2028, but IIRC @bluejekyll wasn't a fan.

kerem commented

2026-03-16 01:10:39 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 2, 2025):

Is this still an issue with all the cleanup in this area, @djc?

@bluejekyll commented on GitHub (Mar 2, 2025): Is this still an issue with all the cleanup in this area, @djc?

kerem commented

2026-03-16 01:10:44 +03:00

Author

Owner

@djc commented on GitHub (Mar 2, 2025):

We don't run MSRV jobs with most of our features, so there could still be regressions in older toolchain support for some of our optional features.

@djc commented on GitHub (Mar 2, 2025): We don't run MSRV jobs with most of our features, so there could still be regressions in older toolchain support for some of our optional features.