[GH-ISSUE #306] trust_dns_server: Message not re-exported from proto crate. #433

Closed
opened 2026-03-15 22:27:54 +03:00 by kerem · 2 comments
Owner

Originally created by @vi on GitHub (Dec 1, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/306

README tells that trust-dns-proto is "not intended for end-user use.".
But to use trust_dns_server::server::RequestHandler, one needs trust_dns_proto::op::message::Message.
I expected it (along with other relevant types) to be re-exported in trust_dns_server, but it seems to be not the case.

This forces users to depend also on trust_dns_proto if they want to depend on trust_dns_server in order to implement a DNS server. Or is the only "indended for end-user" usage is though the trust_dns_server::authority::Catalog?

Originally created by @vi on GitHub (Dec 1, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/306 README tells that trust-dns-proto is "not intended for end-user use.". But to use `trust_dns_server::server::RequestHandler`, one needs `trust_dns_proto::op::message::Message`. I expected it (along with other relevant types) to be re-exported in `trust_dns_server`, but it seems to be not the case. This forces users to depend also on `trust_dns_proto` if they want to depend on `trust_dns_server` in order to implement a DNS server. Or is the only "indended for end-user" usage is though the `trust_dns_server::authority::Catalog`?
Author
Owner

@bluejekyll commented on GitHub (Dec 1, 2017):

Ah, this is a great point. We should probably come up with a proto prelude which the resolver, client and server all reexport that prelude.

<!-- gh-comment-id:348626283 --> @bluejekyll commented on GitHub (Dec 1, 2017): Ah, this is a great point. We should probably come up with a proto prelude which the resolver, client and server all reexport that prelude.
Author
Owner

@bluejekyll commented on GitHub (Apr 20, 2021):

proto is now reexported in-total.

<!-- gh-comment-id:822885452 --> @bluejekyll commented on GitHub (Apr 20, 2021): proto is now reexported in-total.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#433
No description provided.