[PR #433] [CLOSED] (WIP) conversion to tokio-executor #1431

New issue

Closed

opened 2026-03-16 02:06:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:06:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/433
Author: @justinlatimer
Created: 4/27/2018
Status: ❌ Closed

Base: master ← Head: tokio-executor

📝 Commits (3)

bbc5783 Initial conversion to tokio-executor.
23c8817 drop use of tokio_core::reactor::Handle
afc549b hide tokio_reactor::Handle as much as possible

📊 Changes

40 files changed (+173 additions, -260 deletions)

View changed files

📝 Cargo.lock (+1 -1)
📝 client/Cargo.toml (+0 -1)
📝 client/src/client/client.rs (+15 -15)
📝 client/src/client/client_connection.rs (+3 -3)
📝 client/src/client/client_future.rs (+5 -14)
📝 client/src/lib.rs (+0 -1)
📝 client/src/multicast/mdns_client_connection.rs (+2 -4)
📝 client/src/tcp/tcp_client_connection.rs (+2 -2)
📝 client/src/udp/udp_client_connection.rs (+2 -2)
📝 integration-tests/src/lib.rs (+6 -6)
📝 integration-tests/src/tls_client_connection.rs (+2 -2)
📝 integration-tests/tests/client_future_tests.rs (+6 -10)
📝 integration-tests/tests/lookup_tests.rs (+0 -2)
📝 integration-tests/tests/name_server_pool_tests.rs (+3 -6)
📝 integration-tests/tests/secure_client_handle_tests.rs (+3 -3)
📝 native-tls/src/tls_client_stream.rs (+4 -4)
📝 native-tls/src/tls_stream.rs (+2 -2)
📝 openssl/src/tls_client_stream.rs (+4 -4)
📝 openssl/src/tls_stream.rs (+2 -2)
📝 proto/Cargo.toml (+1 -0)

...and 20 more files

📄 Description

This is the last major part of #385, Port to tokio.

Moves from tokio_core::reactor::Handle::spawn() to tokio_executor::spawn. Adds all of the constraints to deal with the multi-threaded executor.

I removed some explicit type annotations where it made it easier to make the compiler happy, I can put these back and fix them up if that's preferred.

Still to do:

Quite a few tests don't pass because the default executor is not always configured when spawn is called.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/433 **Author:** [@justinlatimer](https://github.com/justinlatimer) **Created:** 4/27/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tokio-executor` --- ### 📝 Commits (3) - [`bbc5783`](https://github.com/hickory-dns/hickory-dns/commit/bbc5783c17d6d300efc9dda75298f183dc475500) Initial conversion to tokio-executor. - [`23c8817`](https://github.com/hickory-dns/hickory-dns/commit/23c88178eae21826a9a4a552005bf1a315774f4f) drop use of tokio_core::reactor::Handle - [`afc549b`](https://github.com/hickory-dns/hickory-dns/commit/afc549b02b4c7e4ecb09a164705cbcae2c186e47) hide tokio_reactor::Handle as much as possible ### 📊 Changes **40 files changed** (+173 additions, -260 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -1) 📝 `client/Cargo.toml` (+0 -1) 📝 `client/src/client/client.rs` (+15 -15) 📝 `client/src/client/client_connection.rs` (+3 -3) 📝 `client/src/client/client_future.rs` (+5 -14) 📝 `client/src/lib.rs` (+0 -1) 📝 `client/src/multicast/mdns_client_connection.rs` (+2 -4) 📝 `client/src/tcp/tcp_client_connection.rs` (+2 -2) 📝 `client/src/udp/udp_client_connection.rs` (+2 -2) 📝 `integration-tests/src/lib.rs` (+6 -6) 📝 `integration-tests/src/tls_client_connection.rs` (+2 -2) 📝 `integration-tests/tests/client_future_tests.rs` (+6 -10) 📝 `integration-tests/tests/lookup_tests.rs` (+0 -2) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+3 -6) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+3 -3) 📝 `native-tls/src/tls_client_stream.rs` (+4 -4) 📝 `native-tls/src/tls_stream.rs` (+2 -2) 📝 `openssl/src/tls_client_stream.rs` (+4 -4) 📝 `openssl/src/tls_stream.rs` (+2 -2) 📝 `proto/Cargo.toml` (+1 -0) _...and 20 more files_ </details> ### 📄 Description This is the last major part of #385, Port to tokio. Moves from `tokio_core::reactor::Handle::spawn()` to `tokio_executor::spawn`. Adds all of the constraints to deal with the multi-threaded executor. I removed some explicit type annotations where it made it easier to make the compiler happy, I can put these back and fix them up if that's preferred. Still to do: - [ ] Quite a few tests don't pass because the default executor is not always configured when `spawn` is called. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>