[PR #438] [MERGED] Switch to tokio-executor, drop use of tokio_core::reactor::Handle #1436

New issue

Closed

opened 2026-03-16 02:06:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:06:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/438
Author: @bluejekyll
Created: 4/29/2018
Status: ✅ Merged
Merged: 4/29/2018
Merged by: @bluejekyll

Base: master ← Head: Keruspe-tokio-executor

📝 Commits (6)

d970a80 Initial conversion to tokio-executor.
165b9cf add mutex to catalogue in itegration tests
9073688 drop use of tokio_core::reactor::Handle
dafdb73 resolver: drop leftover references to tokio_reactor::Handle
4136181 dns_future: workaround spawn bug by using thread + run
2d7cb6b fix race condition on query_id

📊 Changes

43 files changed (+257 additions, -341 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 client/src/client/client.rs (+15 -15)
📝 client/src/client/client_connection.rs (+3 -3)
📝 client/src/client/client_future.rs (+5 -14)
📝 client/src/multicast/mdns_client_connection.rs (+2 -2)
📝 client/src/tcp/tcp_client_connection.rs (+2 -2)
📝 client/src/udp/udp_client_connection.rs (+2 -2)
📝 compatibility-tests/src/lib.rs (+1 -1)
📝 integration-tests/src/lib.rs (+20 -17)
📝 integration-tests/src/tls_client_connection.rs (+2 -2)
📝 integration-tests/tests/client_future_tests.rs (+27 -44)
📝 integration-tests/tests/client_tests.rs (+5 -5)
📝 integration-tests/tests/lookup_tests.rs (+8 -18)
📝 integration-tests/tests/mdns_tests.rs (+2 -2)
📝 integration-tests/tests/name_server_pool_tests.rs (+16 -37)
📝 integration-tests/tests/secure_client_handle_tests.rs (+7 -7)
📝 native-tls/src/tls_client_stream.rs (+4 -4)
📝 native-tls/src/tls_stream.rs (+2 -2)
📝 openssl/src/tls_client_stream.rs (+4 -4)
📝 openssl/src/tls_stream.rs (+2 -2)

...and 23 more files

📄 Description

Based on #437 and #433, part of #385

This fixes the race condition in DnsFuture

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/438 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/29/2018 **Status:** ✅ Merged **Merged:** 4/29/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `Keruspe-tokio-executor` --- ### 📝 Commits (6) - [`d970a80`](https://github.com/hickory-dns/hickory-dns/commit/d970a8082dbaf7e87be80726504e9da6c7475897) Initial conversion to tokio-executor. - [`165b9cf`](https://github.com/hickory-dns/hickory-dns/commit/165b9cf8001562d066ff86c964ec20185b857de6) add mutex to catalogue in itegration tests - [`9073688`](https://github.com/hickory-dns/hickory-dns/commit/9073688366105992e28d1e3f26be38a0dcbb24e9) drop use of tokio_core::reactor::Handle - [`dafdb73`](https://github.com/hickory-dns/hickory-dns/commit/dafdb736ca28a03345e4f756085bf7902ac3ac30) resolver: drop leftover references to tokio_reactor::Handle - [`4136181`](https://github.com/hickory-dns/hickory-dns/commit/413618144587606481fe0c16f68c11677de8b597) dns_future: workaround spawn bug by using thread + run - [`2d7cb6b`](https://github.com/hickory-dns/hickory-dns/commit/2d7cb6b0485861a36fe531cd544b72fd7aa4eb51) fix race condition on query_id ### 📊 Changes **43 files changed** (+257 additions, -341 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `client/src/client/client.rs` (+15 -15) 📝 `client/src/client/client_connection.rs` (+3 -3) 📝 `client/src/client/client_future.rs` (+5 -14) 📝 `client/src/multicast/mdns_client_connection.rs` (+2 -2) 📝 `client/src/tcp/tcp_client_connection.rs` (+2 -2) 📝 `client/src/udp/udp_client_connection.rs` (+2 -2) 📝 `compatibility-tests/src/lib.rs` (+1 -1) 📝 `integration-tests/src/lib.rs` (+20 -17) 📝 `integration-tests/src/tls_client_connection.rs` (+2 -2) 📝 `integration-tests/tests/client_future_tests.rs` (+27 -44) 📝 `integration-tests/tests/client_tests.rs` (+5 -5) 📝 `integration-tests/tests/lookup_tests.rs` (+8 -18) 📝 `integration-tests/tests/mdns_tests.rs` (+2 -2) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+16 -37) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+7 -7) 📝 `native-tls/src/tls_client_stream.rs` (+4 -4) 📝 `native-tls/src/tls_stream.rs` (+2 -2) 📝 `openssl/src/tls_client_stream.rs` (+4 -4) 📝 `openssl/src/tls_stream.rs` (+2 -2) _...and 23 more files_ </details> ### 📄 Description Based on #437 and #433, part of #385 This fixes the race condition in DnsFuture --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>