[PR #2690] [MERGED] Server configuration tweaks #3243

New issue

Closed

opened 2026-03-16 11:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2690
Author: @djc
Created: 12/19/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @djc

Base: main ← Head: bin-config-tweaks

📝 Commits (10+)

63240d7 bin: yield &Path from ZoneConfig::file()
0e6706e bin: move KeyPurpose below KeyConfig impl
f51762d bin: store KeyConfig::key_path as PathBuf
95b2cef bin: remove getters from KeyConfig
7c2f1c2 proto: rename get_server_zone() to server_zone()
379947c bin: remove unused KeyConfig constructor
0fa12a3 proto: wrap Algorithm tests in test module
0963319 bin: store Algorithm in KeyConfig directly
38fbddb bin: simplify KeyConfig::signer_name()
aa7bb3e bin: inline single-caller method

📊 Changes

6 files changed (+149 additions, -256 deletions)

View changed files

📝 bin/src/dnssec.rs (+73 -137)
📝 bin/src/lib.rs (+7 -54)
📝 bin/tests/integration/authority_battery/dnssec.rs (+5 -4)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+5 -4)
📝 bin/tests/integration/config_tests.rs (+16 -19)
📝 crates/proto/src/dnssec/algorithm.rs (+43 -38)

📄 Description

Follow-up from #2678 (and miscellaneous cleanup).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2690 **Author:** [@djc](https://github.com/djc) **Created:** 12/19/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `bin-config-tweaks` --- ### 📝 Commits (10+) - [`63240d7`](https://github.com/hickory-dns/hickory-dns/commit/63240d73a6767cfd035f9e234475873ad93afd47) bin: yield &Path from ZoneConfig::file() - [`0e6706e`](https://github.com/hickory-dns/hickory-dns/commit/0e6706ee2f314c30685945504e8117f1196c9176) bin: move KeyPurpose below KeyConfig impl - [`f51762d`](https://github.com/hickory-dns/hickory-dns/commit/f51762d095bf18d443e22726b98313435a22fc9b) bin: store KeyConfig::key_path as PathBuf - [`95b2cef`](https://github.com/hickory-dns/hickory-dns/commit/95b2cef53e5d6893921695150cfede57067b229a) bin: remove getters from KeyConfig - [`7c2f1c2`](https://github.com/hickory-dns/hickory-dns/commit/7c2f1c2e3c4fe4e3b9aed9b64dfad160f92c1a13) proto: rename get_server_zone() to server_zone() - [`379947c`](https://github.com/hickory-dns/hickory-dns/commit/379947c86def6d022776bc8fedf7d00b3c55b045) bin: remove unused KeyConfig constructor - [`0fa12a3`](https://github.com/hickory-dns/hickory-dns/commit/0fa12a37c611eb749e67af319b8d5fe4b9d58435) proto: wrap Algorithm tests in test module - [`0963319`](https://github.com/hickory-dns/hickory-dns/commit/0963319b82716167971b1da73482fb8af929dcb8) bin: store Algorithm in KeyConfig directly - [`38fbddb`](https://github.com/hickory-dns/hickory-dns/commit/38fbddb798cd66a108adb7ac181252b4e6384653) bin: simplify KeyConfig::signer_name() - [`aa7bb3e`](https://github.com/hickory-dns/hickory-dns/commit/aa7bb3e5c0b506bb5037402039b26b51354a7d21) bin: inline single-caller method ### 📊 Changes **6 files changed** (+149 additions, -256 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+73 -137) 📝 `bin/src/lib.rs` (+7 -54) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+5 -4) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+5 -4) 📝 `bin/tests/integration/config_tests.rs` (+16 -19) 📝 `crates/proto/src/dnssec/algorithm.rs` (+43 -38) </details> ### 📄 Description Follow-up from #2678 (and miscellaneous cleanup). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>