[PR #3012] [MERGED] Remove unnecessary clippy suppressions #3493

New issue

Closed

opened 2026-03-16 11:46:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:46:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3012
Author: @djc
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @djc

Base: main ← Head: rm-clippy-suppression

📝 Commits (2)

6737b32 Remove unnecessary clippy suppressions
dd22770 client: reformat zone module

📊 Changes

31 files changed (+93 additions, -108 deletions)

View changed files

📝 bin/tests/integration/named_test_rsa_dnssec.rs (+0 -1)
📝 bin/tests/integration/txt_tests.rs (+0 -1)
📝 crates/client/src/client/client.rs (+0 -1)
📝 crates/client/src/rr/zone.rs (+93 -70)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+0 -3)
📝 crates/proto/src/h2/h2_client_stream.rs (+0 -1)
📝 crates/proto/src/http/request.rs (+0 -1)
📝 crates/proto/src/op/message.rs (+0 -1)
📝 crates/proto/src/op/query.rs (+0 -1)
📝 crates/proto/src/op/response_code.rs (+0 -1)
📝 crates/proto/src/rr/domain/name.rs (+0 -3)
📝 crates/proto/src/rr/rdata/aaaa.rs (+0 -1)
📝 crates/proto/src/rr/rdata/opt.rs (+0 -1)
📝 crates/proto/src/serialize/binary/encoder.rs (+0 -1)
📝 crates/proto/src/tcp/tcp_stream.rs (+0 -1)
📝 crates/proto/src/udp/udp_stream.rs (+0 -2)
📝 crates/proto/src/xfer/dns_exchange.rs (+0 -2)
📝 crates/recursor/src/recursor.rs (+0 -1)
📝 crates/resolver/src/h2.rs (+0 -1)
📝 crates/resolver/src/h3.rs (+0 -1)

...and 11 more files

📄 Description

Cleans up most clippy lint suppressions that no longer trigger.

Fixes #2994; with this, all remaining instances of large_enum_variant are for low-count or shortlived instances. We should probably try to rework the whole connection/DnsExchange stuff in proto some time, but I don't think the large enum variants are an important aspect of that problem.

Follow up from:

#3000
#3001

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3012 **Author:** [@djc](https://github.com/djc) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `rm-clippy-suppression` --- ### 📝 Commits (2) - [`6737b32`](https://github.com/hickory-dns/hickory-dns/commit/6737b32decd048dfd8c15037a878825392cd336c) Remove unnecessary clippy suppressions - [`dd22770`](https://github.com/hickory-dns/hickory-dns/commit/dd227706627c28c09593fb054b6acbe914d33ad4) client: reformat zone module ### 📊 Changes **31 files changed** (+93 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+0 -1) 📝 `bin/tests/integration/txt_tests.rs` (+0 -1) 📝 `crates/client/src/client/client.rs` (+0 -1) 📝 `crates/client/src/rr/zone.rs` (+93 -70) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+0 -3) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+0 -1) 📝 `crates/proto/src/http/request.rs` (+0 -1) 📝 `crates/proto/src/op/message.rs` (+0 -1) 📝 `crates/proto/src/op/query.rs` (+0 -1) 📝 `crates/proto/src/op/response_code.rs` (+0 -1) 📝 `crates/proto/src/rr/domain/name.rs` (+0 -3) 📝 `crates/proto/src/rr/rdata/aaaa.rs` (+0 -1) 📝 `crates/proto/src/rr/rdata/opt.rs` (+0 -1) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+0 -1) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+0 -1) 📝 `crates/proto/src/udp/udp_stream.rs` (+0 -2) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+0 -2) 📝 `crates/recursor/src/recursor.rs` (+0 -1) 📝 `crates/resolver/src/h2.rs` (+0 -1) 📝 `crates/resolver/src/h3.rs` (+0 -1) _...and 11 more files_ </details> ### 📄 Description Cleans up most clippy lint suppressions that no longer trigger. Fixes #2994; with this, all remaining instances of `large_enum_variant` are for low-count or shortlived instances. We should probably try to rework the whole connection/`DnsExchange` stuff in proto some time, but I don't think the large enum variants are an important aspect of that problem. Follow up from: - #3000 - #3001 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>