[PR #2397] [MERGED] proto: simplify verify_dnskey_rrset() #3012

New issue

Closed

opened 2026-03-16 11:20:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:20:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2397
Author: @djc
Created: 8/30/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @djc

Base: main ← Head: simplify-validation

📝 Commits (1)

e7da592 proto: simplify verify_dnskey_rrset()

📊 Changes

1 file changed (+23 additions, -32 deletions)

View changed files

📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+23 -32)

📄 Description

r? @japaric

There seems to be a bunch of unnecessary complexity in this code (tracking indexes that just go unused). I think this does the same thing, but is IMO a lot easier to follow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2397 **Author:** [@djc](https://github.com/djc) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simplify-validation` --- ### 📝 Commits (1) - [`e7da592`](https://github.com/hickory-dns/hickory-dns/commit/e7da592c8d3de34e3fd3cc51647e6ce55e12ad8d) proto: simplify verify_dnskey_rrset() ### 📊 Changes **1 file changed** (+23 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+23 -32) </details> ### 📄 Description r? @japaric There seems to be a bunch of unnecessary complexity in this code (tracking indexes that just go unused). I think this does the same thing, but is IMO a lot easier to follow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>