[PR #2382] [CLOSED] Enable NSEC3 conformance tests for Hickory #3001

New issue

Closed

opened 2026-03-16 11:19:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:19:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2382
Author: @pvdrz
Created: 8/23/2024
Status: ❌ Closed

Base: main ← Head: nsec3-tests-hickory

📝 Commits (10+)

326be34 Implement basic zone signing for NSEC3 records
6c6d185 Add configuration fields for NSEC3
04038e6 Implement basic NSEC3 zone serving
0f2340a Implement NSEC3 zone serving for NODATA responses
6832b3c Document zone serving
64c83e7 Only serve NSEC3 records if NSEC3 is enabled
d0b794d Fix conditional compilation errors
821bdbc Address clippy lints
5b0db27 Merge branch 'main' into nsec3-signing-poc
18db8bc Add NxProof config

📊 Changes

31 files changed (+786 additions, -57 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 bin/src/hickory-dns.rs (+12 -0)
📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+10 -3)
📝 conformance/packages/dns-test/src/container.rs (+1 -1)
📝 conformance/packages/dns-test/src/docker/hickory.Dockerfile (+4 -2)
📝 conformance/packages/dns-test/src/implementation.rs (+18 -11)
📝 conformance/packages/dns-test/src/lib.rs (+5 -2)
📝 conformance/packages/dns-test/src/name_server.rs (+26 -2)
📝 conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja (+8 -0)
📝 conformance/packages/dns-test/src/zone_file/signer.rs (+1 -2)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+2 -1)
📝 crates/server/Cargo.toml (+1 -0)
📝 crates/server/src/authority/authority.rs (+18 -0)
📝 crates/server/src/authority/authority_object.rs (+33 -0)
📝 crates/server/src/authority/catalog.rs (+14 -1)
📝 crates/server/src/authority/error.rs (+4 -0)
📝 crates/server/src/config/mod.rs (+47 -0)
📝 crates/server/src/store/file/authority.rs (+47 -4)
📝 crates/server/src/store/forwarder/authority.rs (+17 -0)
📝 crates/server/src/store/in_memory/authority.rs (+321 -13)

...and 11 more files

📄 Description

blocked by #2344

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2382 **Author:** [@pvdrz](https://github.com/pvdrz) **Created:** 8/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `nsec3-tests-hickory` --- ### 📝 Commits (10+) - [`326be34`](https://github.com/hickory-dns/hickory-dns/commit/326be34ebcc6eee5606219ecbd6c7aa894ac3d15) Implement basic zone signing for NSEC3 records - [`6c6d185`](https://github.com/hickory-dns/hickory-dns/commit/6c6d185c547d484a43c654889ffc7ac8d006a15b) Add configuration fields for NSEC3 - [`04038e6`](https://github.com/hickory-dns/hickory-dns/commit/04038e64a4a0c541fe30c601097be5b3ca12c91c) Implement basic NSEC3 zone serving - [`0f2340a`](https://github.com/hickory-dns/hickory-dns/commit/0f2340a1c41399bfd528f89986020a36e72d30c5) Implement NSEC3 zone serving for NODATA responses - [`6832b3c`](https://github.com/hickory-dns/hickory-dns/commit/6832b3cb05ea310e26e1ee333afc3f48265794ab) Document zone serving - [`64c83e7`](https://github.com/hickory-dns/hickory-dns/commit/64c83e78b32de6b44f0660f23ad1a99d59370ec9) Only serve NSEC3 records if NSEC3 is enabled - [`d0b794d`](https://github.com/hickory-dns/hickory-dns/commit/d0b794d32853f49b6a2a417c5f01c29fed2dad7a) Fix conditional compilation errors - [`821bdbc`](https://github.com/hickory-dns/hickory-dns/commit/821bdbc7b48da124d4db4767c04777b269496c82) Address clippy lints - [`5b0db27`](https://github.com/hickory-dns/hickory-dns/commit/5b0db27a6fc94d1f62ea2c52db6237ee657dc751) Merge branch 'main' into nsec3-signing-poc - [`18db8bc`](https://github.com/hickory-dns/hickory-dns/commit/18db8bc6621b4f1f403f18453c6ac5b59f35874f) Add NxProof config ### 📊 Changes **31 files changed** (+786 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `bin/src/hickory-dns.rs` (+12 -0) 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+10 -3) 📝 `conformance/packages/dns-test/src/container.rs` (+1 -1) 📝 `conformance/packages/dns-test/src/docker/hickory.Dockerfile` (+4 -2) 📝 `conformance/packages/dns-test/src/implementation.rs` (+18 -11) 📝 `conformance/packages/dns-test/src/lib.rs` (+5 -2) 📝 `conformance/packages/dns-test/src/name_server.rs` (+26 -2) 📝 `conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja` (+8 -0) 📝 `conformance/packages/dns-test/src/zone_file/signer.rs` (+1 -2) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+2 -1) 📝 `crates/server/Cargo.toml` (+1 -0) 📝 `crates/server/src/authority/authority.rs` (+18 -0) 📝 `crates/server/src/authority/authority_object.rs` (+33 -0) 📝 `crates/server/src/authority/catalog.rs` (+14 -1) 📝 `crates/server/src/authority/error.rs` (+4 -0) 📝 `crates/server/src/config/mod.rs` (+47 -0) 📝 `crates/server/src/store/file/authority.rs` (+47 -4) 📝 `crates/server/src/store/forwarder/authority.rs` (+17 -0) 📝 `crates/server/src/store/in_memory/authority.rs` (+321 -13) _...and 11 more files_ </details> ### 📄 Description blocked by #2344 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>